-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 43481, 43419, 42741, 43480) controller: work around milliseconds skew in AddAfter AddAfter is not requeueing precisely after the provided time and may skew for some millieseconds. This is really important because controllers don't relist often so a missed check because of ms difference is essentially dropping the key. For example, in [1] the test requeues a Deployment for a progress check after 10s[2] but the Deployment is synced 9ms earlier ending up in the controller not recognizing the Deployment as failed thus dropping it from the queue w/o any error. The drop is fixed by forcing the controller to resync the Deployment but we are going to resync after the full duration. @deads2k if you don't like this I am going to handle this on a case by case basis [1] https://github.com/kubernetes/kubernetes/issues/39785#issuecomment-279959133 [2] https://github.com/kubernetes/kubernetes/blob/c48b2cab0f25abd374ae9308afb19735a4150e19/test/e2e/deployment.go#L1122
00938eac