• Kubernetes Submit Queue's avatar
    Merge pull request #46973 from php-coder/improve_flex_logging · 86a42b87
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 46973, 48556)
    
    Improve error reporting when flex driver has failed to initialize
    
    **What this PR does / why we need it**:
    
    This PR improves error reporting for the case when flex driver is failing to initialize. There are 2 improvements:
    
    1) show only the plugin name instead of a full struct. This makes a message shorter and removes useless and internal information.
    
    Before:
    >E0605 16:44:59.330215   26786 plugins.go:359] Failed to load volume plugin &{k8s/nfs /usr/libexec/kubernetes/kubelet-plugins/volume/exec/k8s~nfs %!s(*kubelet.kubeletVolumeHost=&{0xc431ea5800 {{1 0} map[kubernetes.io/downward-api:0xc431ee3f20 kubernetes.io/aws-ebs:0xc431ee3eb0 kubernetes.io/git-repo:0xc431ee3ef0 kubernetes.io/host-path:0xc430e985f0 kubernetes.io/rbd:0xc42bfab840 kubernetes.io/quobyte:0xc431ee3f00 kubernetes.io/fc:0xc42bfab980 kubernetes.io/empty-dir:0xc431ee3ed0 kubernetes.io/nfs:0xc430e98640 kubernetes.io/iscsi:0xc42bfab720 kubernetes.io/glusterfs:0xc430faaba0 kubernetes.io/cinder:0xc42bfab8c0 kubernetes.io/gce-pd:0xc431ee3ee0 kubernetes.io/secret:0xc42bfab6a0 kubernetes.io/flocker:0xc431ee3f30 kubernetes.io/cephfs:0xc431ee3f10]} 0xc42698cf40}) %!s(*exec.executor=&{}) {%!s(int32=0) %!s(uint32=0)} []}, error: unexpected end of JSON input
    
    After:
    >E0605 16:59:45.520185   29041 plugins.go:359] Failed to load volume plugin k8s/nfs, error: unexpected end of JSON input
    
    2) quote script output. In case the output was empty, messages look a bit better:
    
    Before:
    > E0605 16:44:59.330077   26786 driver-call.go:212] Failed to unmarshal output for command: init, **output: **, error: unexpected end of JSON input
    > W0605 16:44:59.330170   26786 driver-call.go:140] FlexVolume: driver call failed: executable: /usr/libexec/kubernetes/kubelet-plugins/volume/exec/k8s\~nfs/nfs, args: [init], error: fork/exec /usr/libexec/kubernetes/kubelet-plugins/volume/exec/k8s\~nfs/nfs: permission denied, **output: **
    
    After:
    >E0605 16:59:45.519906   29041 driver-call.go:212] Failed to unmarshal output for command: init, **output: ""**, error: unexpected end of JSON input
    >W0605 16:59:45.520109   29041 driver-call.go:140] FlexVolume: driver call failed: executable: /usr/libexec/kubernetes/kubelet-plugins/volume/exec/k8s\~nfs/nfs, args: [init], error: fork/exec /usr/libexec/kubernetes/kubelet-plugins/volume/exec/k8s\~nfs/nfs: permission denied, **output: ""**
    86a42b87
Name
Last commit
Last update
..
BUILD Loading commit data...
OWNERS Loading commit data...
attacher-defaults.go Loading commit data...
attacher.go Loading commit data...
attacher_test.go Loading commit data...
common_test.go Loading commit data...
detacher-defaults.go Loading commit data...
detacher.go Loading commit data...
detacher_test.go Loading commit data...
driver-call.go Loading commit data...
flexvolume_test.go Loading commit data...
mounter-defaults.go Loading commit data...
mounter.go Loading commit data...
mounter_test.go Loading commit data...
plugin-defaults.go Loading commit data...
plugin.go Loading commit data...
plugin_test.go Loading commit data...
probe.go Loading commit data...
unmounter-defaults.go Loading commit data...
unmounter.go Loading commit data...
unmounter_test.go Loading commit data...
util.go Loading commit data...
volume.go Loading commit data...