• Kubernetes Submit Queue's avatar
    Merge pull request #57340 from jmcmeek/jmcmeek_57044 · f5d5d18b
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Fix garbage collector when leader-elect=false
    
    **What this PR does / why we need it**:
    
    In a 1.8.x master with --leader-elect=false, the garbage collector controller
    does not work.
    
    When deleting a deployment with v1meta.DeletePropagationForeground, the deployment
    had its deletionTimestamp set and a foreground Deletion finalizer was added,
    but the deployment, rs and pod were not deleted.
    
    This is an issue with how the garbage collector graph_builder behaves when the
    stopCh=nil.  This PR creates a dummy stop channel for the garbage collector controller (and other
    controllers started by the controller-manager) so that they can work more like they do when
    when the controller-manager is configured with --leader-elect=true.
    
    **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
    Fixes #57044
    
    **Special notes for your reviewer**:
    
    **Release note**:
    
    ```release-note
    Fix garbage collection when the controller-manager uses --leader-elect=false
    ```
    f5d5d18b
Name
Last commit
Last update
..
clicheck Loading commit data...
cloud-controller-manager Loading commit data...
controller-manager/app/options Loading commit data...
gendocs Loading commit data...
genkubedocs Loading commit data...
genman Loading commit data...
genswaggertypedocs Loading commit data...
genutils Loading commit data...
genyaml Loading commit data...
gke-certificates-controller Loading commit data...
hyperkube Loading commit data...
importverifier Loading commit data...
kube-apiserver Loading commit data...
kube-controller-manager Loading commit data...
kube-proxy Loading commit data...
kubeadm Loading commit data...
kubectl Loading commit data...
kubelet Loading commit data...
kubemark Loading commit data...
linkcheck Loading commit data...
BUILD Loading commit data...
OWNERS Loading commit data...