• Kubernetes Submit Queue's avatar
    Merge pull request #31353 from juanvallejo/jvallejo_fix-duplicate-errors-kubectl-set-env · bda57b8f
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue
    
    fix duplicate validation/field/errors
    
    **Release note**:
    
    ``` release-note
    release-note-none
    ```
    
    Related PR: https://github.com/kubernetes/kubernetes/pull/30313
    
    PR #30313 fixed duplicate errors for invalid aggregate errors in
    https://github.com/kubernetes/kubernetes/blob/master/pkg/kubectl/cmd/util/helpers.go
    
    However, duplicate aggregate errors that went through
    https://github.com/kubernetes/kubernetes/blob/master/pkg/util/validation/field/errors.go
    were not affected by that patch.
    
    This patch adds duplicate aggregate error checking to
    `pkg/util/validation/field/errors.go`
    ##### Before
    
    `$ kubectl set env rc/idling-echo-1 test-abc=1234`
    
    ```
    error: ReplicationController "idling-echo-1" is invalid:
    [spec.template.spec.containers[0].env[0].name: Invalid value:
    "test-abc": must be a C identifier (matching regex
    [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName",
    spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc":
    must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g.
    "my_name" or "MyName", spec.template.spec.containers[0].env[0].name:
    Invalid value: "test-abc": must be a C identifier (matching regex
    [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName",
    spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc":
    must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g.
    "my_name" or "MyName"]
    ```
    
    `$ kubectl set env rc/node-1 test-abc=1234`
    
    ```
    error: ReplicationController "idling-echo-1" is invalid:
    [spec.template.spec.containers[0].env[0].name: Invalid value:
    "test-abc": must be a C identifier (matching regex
    [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName",
    spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc":
    must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g.
    "my_name" or "MyName"]
    ```
    ##### After
    
    `$ kubectl set env rc/idling-echo-1 test-abc=1234`
    
    ```
    error: ReplicationController "idling-echo-1" is invalid:
    [spec.template.spec.containers[0].env[0].name: Invalid value:
    "test-abc": must be a C identifier (matching regex
    [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName",
    spec.template.spec.containers[1].env[0].name: Invalid value: "test-abc":
    must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g.
    "my_name" or "MyName"]
    ```
    
    `$ kubectl set env rc/node-1 test-abc=1234`
    
    ```
    error: ReplicationController "node-1" is invalid:
    spec.template.spec.containers[0].env[0].name: Invalid value: "test-abc":
    must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g.
    "my_name" or "MyName"
    ```
    bda57b8f
Name
Last commit
Last update
..
async Loading commit data...
bandwidth Loading commit data...
cache Loading commit data...
cert Loading commit data...
chmod Loading commit data...
chown Loading commit data...
clock Loading commit data...
codeinspector Loading commit data...
config Loading commit data...
configz Loading commit data...
crlf Loading commit data...
dbus Loading commit data...
diff Loading commit data...
ebtables Loading commit data...
env Loading commit data...
errors Loading commit data...
exec Loading commit data...
flag Loading commit data...
flock Loading commit data...
flowcontrol Loading commit data...
flushwriter Loading commit data...
framer Loading commit data...
goroutinemap Loading commit data...
hash Loading commit data...
homedir Loading commit data...
httpstream Loading commit data...
initsystem Loading commit data...
integer Loading commit data...
interrupt Loading commit data...
intstr Loading commit data...
io Loading commit data...
iptables Loading commit data...
json Loading commit data...
jsonpath Loading commit data...
keymutex Loading commit data...
labels Loading commit data...
limitwriter Loading commit data...
logs Loading commit data...
maps Loading commit data...
metrics Loading commit data...
mount Loading commit data...
net Loading commit data...
netsh Loading commit data...
node Loading commit data...
oom Loading commit data...
parsers Loading commit data...
procfs Loading commit data...
proxy Loading commit data...
rand Loading commit data...
resourcecontainer Loading commit data...
rlimit Loading commit data...
runtime Loading commit data...
selinux Loading commit data...
sets Loading commit data...
slice Loading commit data...
strategicpatch Loading commit data...
strings Loading commit data...
sysctl Loading commit data...
system Loading commit data...
taints Loading commit data...
term Loading commit data...
testing Loading commit data...
threading Loading commit data...
uuid Loading commit data...
validation Loading commit data...
wait Loading commit data...
workqueue Loading commit data...
wsstream Loading commit data...
yaml Loading commit data...
BUILD Loading commit data...
doc.go Loading commit data...
template.go Loading commit data...
template_test.go Loading commit data...
trace.go Loading commit data...
trie.go Loading commit data...
umask.go Loading commit data...
umask_windows.go Loading commit data...
util.go Loading commit data...
util_test.go Loading commit data...