• Kubernetes Submit Queue's avatar
    Merge pull request #44221 from ncdc/fix-validateClusterInfo-empty-cluster-check · f1b9c17c
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 43545, 44293, 44221, 43888)
    
    validateClusterInfo: use clientcmdapi.NewCluster()
    
    Change validateClusterInfo to use clientcmdapi.NewCluster() instead of
    clientcmdapi.Cluster{} when comparing against the passed in clusterInfo.
    clusterInfo most likely will be a combination of
    clientcmdapi.NewCluster() merged with potential overrides. This is
    necessary because otherwise, the DeepEqual between what is supposed to
    be an empty Cluster and clusterInfo will fail, resulting in an error
    that doesn't allow fall-through to checking for in-cluster
    configuration.
    
    https://github.com/kubernetes/kubernetes/pull/40508 changed `DirectClientConfig.getContext()` to start with a `clientcmdapi.NewCluster()` instead of the zero value for `clientcmdapi.Cluster`. This means that the `Extensions` map in the `Cluster` is initialized instead of `nil`, which breaks the `DeepEqual` test unless you compare `clusterInfo` against an initialized `clientcmdapi.NewCluster()`.
    
    cc @smarterclayton @sttts @vjsamuel @liggitt @deads2k @soltysh @fabianofranz @kubernetes/sig-api-machinery-pr-reviews
    f1b9c17c
Name
Last commit
Last update
..
src/k8s.io Loading commit data...
README.md Loading commit data...
copy.sh Loading commit data...
godeps-json-updater.go Loading commit data...
prime-apimachinery.sh Loading commit data...