• Kubernetes Submit Queue's avatar
    Merge pull request #49202 from cbonte/node-addresses · a51eb2ac
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 51728, 49202)
    
    Fix setNodeAddress when a node IP and a cloud provider are set
    
    **What this PR does / why we need it**:
    When a node IP is set and a cloud provider returns the same address with
    several types, only the first address was accepted. With the changes made
    in PR #45201, the vSphere cloud provider returned the ExternalIP first,
    which led to a node without any InternalIP.
    
    The behaviour is modified to return all the address types for the
    specified node IP.
    
    **Which issue this PR fixes**: fixes #48760
    
    **Special notes for your reviewer**:
    * I'm not a golang expert, is it possible to mock `kubelet.validateNodeIP()` to avoid the need of real host interface addresses in the test ?
    * It would be great to have it backported for a next 1.6.8 release.
    
    **Release note**:
    ```release-note
    NONE
    ```
    a51eb2ac
Name
Last commit
Last update
..
api Loading commit data...
apimachinery/tests Loading commit data...
apis Loading commit data...
auth Loading commit data...
bootstrap/api Loading commit data...
capabilities Loading commit data...
client Loading commit data...
cloudprovider Loading commit data...
controller Loading commit data...
credentialprovider Loading commit data...
features Loading commit data...
fieldpath Loading commit data...
generated Loading commit data...
hyperkube Loading commit data...
kubeapiserver Loading commit data...
kubectl Loading commit data...
kubelet Loading commit data...
kubemark Loading commit data...
master Loading commit data...
printers Loading commit data...
probe Loading commit data...
proxy Loading commit data...
quota Loading commit data...
registry Loading commit data...
routes Loading commit data...
security Loading commit data...
securitycontext Loading commit data...
serviceaccount Loading commit data...
ssh Loading commit data...
util Loading commit data...
version Loading commit data...
volume Loading commit data...
watch Loading commit data...
BUILD Loading commit data...
OWNERS Loading commit data...