• Kubernetes Submit Queue's avatar
    Merge pull request #34010 from soltysh/fix_edit_sj · 049ad985
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue
    
    Match GroupVersionKind against specific version
    
    Currently when multiple GVK match a specific kind in `KindForGroupVersionKinds` only the first will be matched, which not necessarily will be the correct one. I'm proposing to extend this to pick the best match, instead.
    
    Here's my problematic use-case, of course it involves ScheduledJobs :wink::
    I have a `GroupVersions` with `batch/v1` and `batch/v2alpha1` in that order. I'm calling `KindForGroupVersionKinds` with kind `batch/v2alpha1 ScheduledJob` and that currently results this matching first `GroupVersion`, instead of picking more concrete one. There's a [clear description](https://github.com/kubernetes/kubernetes/blob/ee77d4e6ca1e174a189071e50997a377bcb6fc37/pkg/api/unversioned/group_version.go#L183) why it is on single `GroupVersion`, but `GroupVersions` should pick this more carefully.
    
    @deads2k this is your baby, wdyt?
    049ad985
Name
Last commit
Last update
..
serializer Loading commit data...
OWNERS Loading commit data...
codec.go Loading commit data...
codec_check.go Loading commit data...
conversion.go Loading commit data...
conversion_test.go Loading commit data...
doc.go Loading commit data...
embedded.go Loading commit data...
embedded_test.go Loading commit data...
error.go Loading commit data...
extension.go Loading commit data...
extension_test.go Loading commit data...
generated.pb.go Loading commit data...
generated.proto Loading commit data...
helper.go Loading commit data...
helper_test.go Loading commit data...
interfaces.go Loading commit data...
register.go Loading commit data...
scheme.go Loading commit data...
scheme_builder.go Loading commit data...
scheme_test.go Loading commit data...
swagger_doc_generator.go Loading commit data...
swagger_doc_generator_test.go Loading commit data...
types.go Loading commit data...
types_proto.go Loading commit data...
unstructured.go Loading commit data...
unstructured_test.go Loading commit data...
unversioned_test.go Loading commit data...
zz_generated.deepcopy.go Loading commit data...