• Rostislav M. Georgiev's avatar
    kubeadm: Don't error out on join with --cri-socket override · 8921f033
    Rostislav M. Georgiev authored
    In the case where newControlPlane is true we don't go through
    getNodeRegistration() and initcfg.NodeRegistration.CRISocket is empty.
    This forces DetectCRISocket() to be called later on, and if there is more than
    one CRI installed on the system, it will error out, while asking for the user
    to provide an override for the CRI socket. Even if the user provides an
    override, the call to DetectCRISocket() can happen too early and thus ignore it
    (while still erroring out).
    However, if newControlPlane == true, initcfg.NodeRegistration is not used at
    all and it's overwritten later on.
    Thus it's necessary to supply some default value, that will avoid the call to
    DetectCRISocket() and as initcfg.NodeRegistration is discarded, setting
    whatever value here is harmless.
    Signed-off-by: 's avatarRostislav M. Georgiev <rostislavg@vmware.com>
    8921f033
Name
Last commit
Last update
..
strict Loading commit data...
testdata Loading commit data...
BUILD Loading commit data...
cluster.go Loading commit data...
cluster_test.go Loading commit data...
common.go Loading commit data...
common_test.go Loading commit data...
initconfiguration.go Loading commit data...
initconfiguration_test.go Loading commit data...
joinconfiguration.go Loading commit data...
joinconfiguration_test.go Loading commit data...