• Kubernetes Submit Queue's avatar
    Merge pull request #67316 from m1kola/67314_fix_regression · 4fff3523
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 66920, 67316, 67363, 67528, 66963). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Fixes regression in kubectl logs: the --all-containers=true option didn't work
    
    **What this PR does / why we need it**:
    
    Fixes regression introduced in #66398 and adds unit tests for logging with `--all-containers=true`. See #67314 for more details.
    
    **Which issue(s) this PR fixes**:
    Fixes #67314
    
    **Special notes for your reviewer**:
    
    I didn't cover cases with `coreinternal.PodList` and `coreinternal.Pod` in tests, because it doesn't look like we need them: I didn't manage to find any callers of the `logsForObjectWithClient` and `logsForObject` functions, so, probably, we can remove them. I'll double check and try to do that separately once this PR is merged.
    
    **Release note**:
    ```release-note
    NONE
    ```
    
    /sig cli
    4fff3523
Name
Last commit
Last update
..
BUILD Loading commit data...
attachablepodforobject.go Loading commit data...
canbeautoscaled.go Loading commit data...
canbeautoscaled_test.go Loading commit data...
canbeexposed.go Loading commit data...
canbeexposed_test.go Loading commit data...
helpers.go Loading commit data...
helpers_test.go Loading commit data...
historyviewer.go Loading commit data...
interface.go Loading commit data...
logsforobject.go Loading commit data...
logsforobject_test.go Loading commit data...
mapbasedselectorforobject.go Loading commit data...
mapbasedselectorforobject_test.go Loading commit data...
objectpauser.go Loading commit data...
objectpauser_test.go Loading commit data...
objectresumer.go Loading commit data...
objectresumer_test.go Loading commit data...
portsforobject.go Loading commit data...
portsforobject_test.go Loading commit data...
protocolsforobject.go Loading commit data...
protocolsforobject_test.go Loading commit data...
rollbacker.go Loading commit data...
statusviewer.go Loading commit data...
updatepodspec.go Loading commit data...
updatepodspec_test.go Loading commit data...