• Kubernetes Submit Queue's avatar
    Merge pull request #40142 from colemickens/colemickens-acr-login-server · d62fca23
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 37055, 40142)
    
    azure: azure container registry: fix login server
    
    **What this PR does / why we need it**:
    
    Fixes the Azure Container Registry integration
    
    **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
    n/a
    
    **Special notes for your reviewer**:
    
    Before this change, if I created an ACR with name `colemicktest`, then the login server would be `colemicktest-microsoft.azurecr.io`. This code was concating to form `colemicktest.azurecr.io` which does not work.
    
    The fix is to reach into RegistryProperties and read out the login server domain name directly.
    
    Also, this should eliminate that existed when ACR gets to sovereign clouds.
    
    **Release note**:
    
    ```release-note
    azure: fix Azure Container Registry integration
    ```
    d62fca23
Name
Last commit
Last update
..
aws Loading commit data...
azure Loading commit data...
gcp Loading commit data...
BUILD Loading commit data...
OWNERS Loading commit data...
config.go Loading commit data...
config_test.go Loading commit data...
doc.go Loading commit data...
keyring.go Loading commit data...
keyring_test.go Loading commit data...
plugins.go Loading commit data...
provider.go Loading commit data...
provider_test.go Loading commit data...