• Akram Ben Aissi's avatar
    Fixes an issue with hosts having an IPv6 address on localhost · 0883bfa6
    Akram Ben Aissi authored
    - When 'getent hosts localhost' returns '::1' the creation of the
      listener fails because of the port parsing which uses ":" as a
    separator
    - Use of net.SplitHostPort() to do the job
    - Adding unit tests to ensure that the creation succeeds
    - On docker.go: adds a test on the presence the socat command which was
      failing silenty if not installed
    
    - Code Review 1
      - Fixed typo on Expected
      - The UT now fails if the PortForwarder could not be created
    
    - Code Review 2
      - Simplify socat error message
      - Changing t.Fatal to to.Error on unit tests
    
    - Code Review 3
      - Removing useless uses cases in unit tests
    
    - Code Review 4
      - Removing useless initiliasiation of PortForwarder
      - Changing error message
    
    - Code Review 5
      - Simplifying TestCast struct
      - Adding addition test in one test case
      - Closing the listener
    
    - Code Review 6
      - Improving unit test
    0883bfa6
Name
Last commit
Last update
..
cache Loading commit data...
chaosclient Loading commit data...
clientcmd Loading commit data...
metrics Loading commit data...
portforward Loading commit data...
record Loading commit data...
remotecommand Loading commit data...
testclient Loading commit data...
testdata Loading commit data...
client.go Loading commit data...
client_test.go Loading commit data...
componentstatuses.go Loading commit data...
conditions.go Loading commit data...
containerinfo.go Loading commit data...
containerinfo_test.go Loading commit data...
doc.go Loading commit data...
endpoints.go Loading commit data...
endpoints_test.go Loading commit data...
events.go Loading commit data...
events_test.go Loading commit data...
fake.go Loading commit data...
flags.go Loading commit data...
flags_test.go Loading commit data...
helper.go Loading commit data...
helper_test.go Loading commit data...
kubelet.go Loading commit data...
kubelet_test.go Loading commit data...
limit_ranges.go Loading commit data...
limit_ranges_test.go Loading commit data...
namespaces.go Loading commit data...
namespaces_test.go Loading commit data...
nodes.go Loading commit data...
nodes_test.go Loading commit data...
persistentvolume_test.go Loading commit data...
persistentvolumeclaim.go Loading commit data...
persistentvolumeclaim_test.go Loading commit data...
persistentvolumes.go Loading commit data...
pods.go Loading commit data...
pods_test.go Loading commit data...
replication_controllers.go Loading commit data...
replication_controllers_test.go Loading commit data...
request.go Loading commit data...
request_test.go Loading commit data...
resource_quotas.go Loading commit data...
resource_quotas_test.go Loading commit data...
restclient.go Loading commit data...
restclient_test.go Loading commit data...
secrets.go Loading commit data...
services.go Loading commit data...
services_test.go Loading commit data...
transport.go Loading commit data...
transport_test.go Loading commit data...