• Kubernetes Submit Queue's avatar
    Merge pull request #49202 from cbonte/node-addresses · a51eb2ac
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 51728, 49202)
    
    Fix setNodeAddress when a node IP and a cloud provider are set
    
    **What this PR does / why we need it**:
    When a node IP is set and a cloud provider returns the same address with
    several types, only the first address was accepted. With the changes made
    in PR #45201, the vSphere cloud provider returned the ExternalIP first,
    which led to a node without any InternalIP.
    
    The behaviour is modified to return all the address types for the
    specified node IP.
    
    **Which issue this PR fixes**: fixes #48760
    
    **Special notes for your reviewer**:
    * I'm not a golang expert, is it possible to mock `kubelet.validateNodeIP()` to avoid the need of real host interface addresses in the test ?
    * It would be great to have it backported for a next 1.6.8 release.
    
    **Release note**:
    ```release-note
    NONE
    ```
    a51eb2ac
Name
Last commit
Last update
.github Loading commit data...
Godeps Loading commit data...
api Loading commit data...
build Loading commit data...
cluster Loading commit data...
cmd Loading commit data...
docs Loading commit data...
examples Loading commit data...
federation Loading commit data...
hack Loading commit data...
logo Loading commit data...
pkg Loading commit data...
plugin Loading commit data...
staging Loading commit data...
test Loading commit data...
third_party Loading commit data...
translations Loading commit data...
vendor Loading commit data...
.bazelrc Loading commit data...
.generated_files Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.kazelcfg.json Loading commit data...
BUILD.bazel Loading commit data...
CHANGELOG.md Loading commit data...
CONTRIBUTING.md Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
Makefile.generated_files Loading commit data...
OWNERS Loading commit data...
OWNERS_ALIASES Loading commit data...
README.md Loading commit data...
SUPPORT.md Loading commit data...
Vagrantfile Loading commit data...
WORKSPACE Loading commit data...
code-of-conduct.md Loading commit data...
labels.yaml Loading commit data...