• Kubernetes Submit Queue's avatar
    Merge pull request #48457 from cofyc/rbd_error · 494ffa46
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 48425, 41680, 48457, 48619, 48635)
    
    "rbd: image xxx is locked by other nodes" is misleading
    
    **What this PR does / why we need it**:
    
    For RWO PV, RBD plugin tries to fence it first, but there are many situations which may cause lock to fail, e.g.
    
    - userSecret is incorrect
    - monitor addresses are incorrect or node cannot access ceph cluster temporarily
    - image is locked by other nodes
    - maybe more...
    
    So, original "image xxx is locked by other nodes" is incorrect in some cases and misleading in diagnosis.
    
    This PR change the error to be correct and not misleading first. We may add detail error descriptions later.
    
    **Special notes for your reviewer**:
    
    New FailedMount event example if RBD plugin cannot lock image:
    
    ```
    ...		FailedMount		MountVolume.SetUp failed for volume "pvc-ee37a9c8-608e-11e7-b3a7-000c291fbe71" : rbd: failed to lock image kubernetes-dynamic-pvc-ee3b9911-608e-11e7-97b6-000c291fbe71 (maybe locked by other nodes), error exit status 22
    ```
    
    **Release note**:
    
    ```release-note
    NONE
    ```
    494ffa46
Name
Last commit
Last update
..
aws_ebs Loading commit data...
azure_dd Loading commit data...
azure_file Loading commit data...
cephfs Loading commit data...
cinder Loading commit data...
configmap Loading commit data...
downwardapi Loading commit data...
empty_dir Loading commit data...
fc Loading commit data...
flexvolume Loading commit data...
flocker Loading commit data...
gce_pd Loading commit data...
git_repo Loading commit data...
glusterfs Loading commit data...
host_path Loading commit data...
iscsi Loading commit data...
local Loading commit data...
nfs Loading commit data...
photon_pd Loading commit data...
portworx Loading commit data...
projected Loading commit data...
quobyte Loading commit data...
rbd Loading commit data...
scaleio Loading commit data...
secret Loading commit data...
storageos Loading commit data...
testing Loading commit data...
util Loading commit data...
validation Loading commit data...
vsphere_volume Loading commit data...
BUILD Loading commit data...
OWNERS Loading commit data...
doc.go Loading commit data...
metrics_cached.go Loading commit data...
metrics_du.go Loading commit data...
metrics_du_test.go Loading commit data...
metrics_errors.go Loading commit data...
metrics_nil.go Loading commit data...
metrics_nil_test.go Loading commit data...
metrics_statfs.go Loading commit data...
metrics_statfs_test.go Loading commit data...
plugins.go Loading commit data...
plugins_test.go Loading commit data...
util.go Loading commit data...
util_test.go Loading commit data...
volume.go Loading commit data...
volume_linux.go Loading commit data...
volume_unsupported.go Loading commit data...