• Kubernetes Submit Queue's avatar
    Merge pull request #36869 from madhusudancs/kubefed-join-context-secret-name-flags · 67dc8739
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue
    
    [Federation][join-flags] Add flags for cluster context and secret names while joining clusters to federation.
    
    Vast majority of cluster contexts are not RFC 1123 subdomains. Since
    cluster and secret names for the API objects are derived from the
    cluster context name, there is no way for users to join clusters
    with such context names to federation, unless they modify the context
    name in their kubeconfigs itself. That's a lot of inconvenience and
    entirely goes against the goal and beats the purpose of the `kubefed`
    tool. So we are providing these flags to allow users to override these
    values.
    
    Also, since users register their clusters with federation, it is makes
    sense in terms of user experience to make the cluster name a positional
    argument because that feels more natural. Also, specifying cluster name
    in the join command as a mandatory positional argument make
    `kubefed join` consistent with `kubefed unjoin`. This also means
    `--cluster-context` is now made a flag and defaults to cluster name if
    unspecified.
    
    `--secret-name` also defaults to the cluster name if unspecified.
    
    Fixes: Issue #35954
    
    cc @kubernetes/sig-cluster-federation @quinton-hoole @irfanurrehman
    67dc8739
Name
Last commit
Last update
..
exceptions.txt Loading commit data...
excluded-flags.txt Loading commit data...
known-flags.txt Loading commit data...