• Kubernetes Submit Queue's avatar
    Merge pull request #64066 from luxas/kubeadm_etcd_refactor · b712eaf2
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 64127, 63895, 64066, 64215, 64202). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    kubeadm: Refactor the .Etcd substruct in the v1alpha2 API
    
    **What this PR does / why we need it**:
    Splits the monolithic `.Etcd` struct with all the options as fields to a more modular and clear design with two sub-structs for the different modes of hosting etcd we support.
    
    **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
    Part of kubernetes/community#2131
    
    **Special notes for your reviewer**:
    Depends on:
     - [x] https://github.com/kubernetes/kubernetes/pull/63917
    
    Follows up: https://github.com/kubernetes/kubernetes/pull/63871
    TODO: I still need to write unit tests for this.
    
    **Release note**:
    
    ```release-note
    [action required] kubeadm: The `:Etcd` struct has been refactored in the v1alpha2 API. All the options now reside under either `.Etcd.Local` or `.Etcd.External`. Automatic conversions from the v1alpha1 API are supported.
    ```
    @kubernetes/sig-cluster-lifecycle-pr-reviews @liztio
    b712eaf2
Name
Last commit
Last update
..
app Loading commit data...
test Loading commit data...
.import-restrictions Loading commit data...
BUILD Loading commit data...
OWNERS Loading commit data...
kubeadm.go Loading commit data...