• k8s-merge-robot's avatar
    Merge pull request #27252 from mfanjie/fix-ensuredns · c7e3b2f6
    k8s-merge-robot authored
    Automatic merge from submit-queue
    
    federation: fix dns provider initialization issues
    
    This PR is based on the integration test with Google DNS API. This is the first time of full integration test.
    So multiple issues was found and I combined all of them in this single PR
    
    1. add dns provider initialization and add ensureDns call when removing federation service.
    2. add new flags federation-name and zone-name to controller manager, both are used as part of the dns record name
    3. fix assertion failure at rrsets.go#L61, which will cause panic
    4. change getFederationDNSZoneName to get zoneName from config instead of hard code
    5. change logic of ensureDnsRrsets, only add new dns record when endpointReachable(set to true when ready address is catched) is true
    6. fix bug in processEndpointUpdate, only call ensuredns when ready address is caught
    7. change behavior of syncService, there is cases that endpoint is created before ingress IP assignment, so before there is defect for this case, ensureDns was not called when service being updated, so if Ingress IP is assigned after endpoint ready address is caught, the corresponding A records can not be created
    8. add a checking before update federation service
    
    @nikhiljindal , can you help to add 1.3 milestone when @quinton-hoole is on leave?
    Thanks.
    
    [![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/.github/PULL_REQUEST_TEMPLATE.md?pixel)]()
    c7e3b2f6
Name
Last commit
Last update
..
apis Loading commit data...
client Loading commit data...
cluster Loading commit data...
cmd Loading commit data...
manifests Loading commit data...
pkg Loading commit data...
registry/cluster Loading commit data...