• Kubernetes Submit Queue's avatar
    Merge pull request #68017 from figo/node-status · 1ad28be4
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 65566, 67959, 68029, 68017, 67263). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.
    
    add test to verify vsphere cloud provider report node hostname
    
    **What this PR does / why we need it**:
    as in pull #67922 has modify vsphere cloud provider to report
    node hostname, this patch is to add the test for it.
    
    also fix an issue at InstanceID(), it suppose to return
    cloudprovider.InstanceNotFound when vm not found,  
    but it did double error type translation with a retry() logic,  
    after removing the retry() (which is not necessary), the logic is simpler, and easier to understand how double translation happened, after the fix,
    test TestInstance() can pass
    
    
    **Which issue(s) this PR fixes** :
    Fixes #67714
    
    
    **Special notes for your reviewer**:
    as in the process of create pull to fix https://github.com/crosscloudci/crosscloudci/issues/65#,
    i saw #67922 already merged, so this pull is just to submit the test part.
    
    **Release note**:
    
    ```release-note
    none
    ```
    
    
    /cc @abrarshivani @BaluDontu @divyenpatel @imkin @kerneltime @luomiao @frapposelli @dougm @liggitt
    /sig cloudprovider
    1ad28be4
Name
Last commit
Last update
..
providers Loading commit data...
BUILD Loading commit data...
OWNERS Loading commit data...
README.md Loading commit data...
cloud.go Loading commit data...
doc.go Loading commit data...
plugins.go Loading commit data...