Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wiki-js
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
1
Issues
1
List
Board
Labels
Milestones
Merge Requests
1
Merge Requests
1
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
wiki-js
Commits
7306fabd
Commit
7306fabd
authored
Apr 24, 2020
by
NGPixel
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix: auto-trim trailing slash from paths + illegal chars check during move
parent
566043ec
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
16 additions
and
1 deletion
+16
-1
pages.js
server/models/pages.js
+16
-1
No files found.
server/models/pages.js
View file @
7306fabd
...
...
@@ -214,10 +214,15 @@ module.exports = class Page extends Model {
*/
static
async
createPage
(
opts
)
{
// -> Validate path
if
(
opts
.
path
.
indexOf
(
'.'
)
>=
0
||
opts
.
path
.
indexOf
(
' '
)
>=
0
)
{
if
(
opts
.
path
.
indexOf
(
'.'
)
>=
0
||
opts
.
path
.
indexOf
(
' '
)
>=
0
||
opts
.
path
.
index
(
'
\
\'
) >= 0
) {
throw new WIKI.Error.PageIllegalPath()
}
// -> Remove trailing slash
if (opts.path.endsWidth('
/
')) {
opts.path = opts.path.slice(0, -1)
}
// -> Check for page access
if (!WIKI.auth.checkAccess(opts.user, ['
write
:
pages
'], {
locale: opts.locale,
...
...
@@ -398,6 +403,16 @@ module.exports = class Page extends Model {
throw new WIKI.Error.PageNotFound()
}
// -> Validate path
if (opts.destinationPath.indexOf('
.
') >= 0 || opts.destinationPath.indexOf('
') >= 0 || opts.destinationPath.index('
\\
') >= 0) {
throw new WIKI.Error.PageIllegalPath()
}
// -> Remove trailing slash
if (opts.destinationPath.endsWidth('
/
')) {
opts.destinationPath = opts.destinationPath.slice(0, -1)
}
// -> Check for source page access
if (!WIKI.auth.checkAccess(opts.user, ['
manage
:
pages
'], {
locale: page.localeCode,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment