Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wiki-js
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
1
Issues
1
List
Board
Labels
Milestones
Merge Requests
1
Merge Requests
1
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
wiki-js
Commits
78d02dc8
Unverified
Commit
78d02dc8
authored
May 09, 2022
by
NGPixel
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix: prevent manage system assignment from manage groups permission
parent
a06201aa
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
0 deletions
+8
-0
group.js
server/graph/resolvers/group.js
+8
-0
No files found.
server/graph/resolvers/group.js
View file @
78d02dc8
...
...
@@ -173,6 +173,14 @@ module.exports = {
throw
new
gql
.
GraphQLError
(
'You are not authorized to manage this group or assign these permissions.'
)
}
// Check assigned permissions for manage:groups
if
(
WIKI
.
auth
.
checkExclusiveAccess
(
req
.
user
,
[
'manage:groups'
],
[
'manage:system'
])
&&
args
.
permissions
.
some
(
p
=>
_
.
last
(
p
.
split
(
':'
))
===
'system'
)
)
{
throw
new
gql
.
GraphQLError
(
'You are not authorized to manage this group or assign the manage:system permissions.'
)
}
// Update group
await
WIKI
.
models
.
groups
.
query
().
patch
({
name
:
args
.
name
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment