fix: search engine broken when renaming or moving pages (#2815)

For building suggest in elasticsearch, the safeContent field will be splitted into arrays. If the page is renamed or moved, the server will throw error: "Cannot read property 'split' of Undefined", and the index will be broken. Here two lines are added to fix this issue.

fix: search engine broken when renaming or moving pages (#2815)
d7d00b44 · scienceasdf · GitHub · a1f1cd73 · d7d00b44
Unverified Commit d7d00b44 authored Dec 14, 2020 by scienceasdf Committed by GitHub Dec 13, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 0 deletions

pages.js server/models/pages.js +2 -0

No files found.
--- a/server/models/pages.js
+++ b/server/models/pages.js
@@ -544,6 +544,8 @@ module.exports = class Page extends Model {
    await WIKI.models.pages.rebuildTree()

    // -> Rename in Search Index
+    const pageContents = await WIKI.models.pages.query().findById(page.id).select('render')
+    page.safeContent = WIKI.models.pages.cleanHTML(pageContents.render)
    await WIKI.data.searchEngine.renamed({
      ...page,
      destinationPath: opts.destinationPath,