image.in/Makefile: mkimage version check

There's a recommended version (0.2.0+ currently) and also the minimal version, 0.1.7, which received the important fixes. It was proposed by nice antique@ folks IIRC. Unfortunately the "suboptimal version" warning is pretty modest, and "minimal version" error will be apparent with DEBUG enabled; still the latter will terminate the downstream build and leave a clear message in build.log at any rate.

image.in/Makefile: mkimage version check
7a8ac9e7 · Michael Shigorin · b3e4d9af · 7a8ac9e7
Commit 7a8ac9e7 authored Nov 08, 2011 by Michael Shigorin
Hide whitespace changes
Inline Side-by-side

Showing with 13 additions and 0 deletions

Makefile image.in/Makefile +13 -0

No files found.
--- a/image.in/Makefile
+++ b/image.in/Makefile
@@ -4,10 +4,23 @@ GLOBAL_BUILDDIR ?= $(shell pwd)
 CURRENT_LINK := mkimage-profiles
 OUT_LINK := out

+# there were mkimage fixes induced by mkimage-profile development
+MKI_VER_MINIMAL = 0.1.7
+MKI_VER_OPTIMAL = 0.2.0
+
 include distcfg.mk
 include functions.mk
 include $(MKIMAGE_PREFIX)/config.mk

+ifeq (-,$(shell rpmvercmp $(MKI_VERSION) $(MKI_VER_MINIMAL) | tr -d [0-9]))
+$(info error: mkimage-$(MKI_VERSION) is too old, please upgrade)
+$(error mkimage is too old, $(MKI_VER_MINIMAL) is minimal supported version)
+endif
+ifeq (-,$(shell rpmvercmp $(MKI_VERSION) $(MKI_VER_OPTIMAL) | tr -d [0-9]))
+$(info warning: mkimage-$(MKI_VERSION) is suboptimal, consider upgrading)
+$(warning consider upgrading mkimage to $(MKI_VER_OPTIMAL) or better)
+endif
+
 # reconstruct instead of passing yet another variable
 IMAGE_LINK := $(IMAGE_NAME).$(IMAGE_TYPE)
 IMAGE_OUTFILE := $(IMAGE_NAME)-$(DATE)-$(ARCH).$(IMAGE_TYPE)