check-recipe: generalize dependency control

An initial (and quite naive) implementation was done for conf.d/ files but features do need it as well -- which became obvious during a casual inspection of distro/alt-workstation's target graph (which occured broken). The code is a messy hackery unfortunately, regexes used are fragile regarding e.g. [A-Z_] in target names. Read with care. NB: lib/ might need this too but it's rather stable and contains some special cases that would obstruct the regexes even more...

check-recipe: generalize dependency control
a2897267 · Michael Shigorin · 949733a9 · a2897267 · a2897267 · a2897267
Commit a2897267 authored Jan 29, 2017 by Michael Shigorin
Hide whitespace changes
Inline Side-by-side

Showing with 18 additions and 4 deletions

check-recipe bin/check-recipe +14 -0

Makefile conf.d/Makefile +1 -4

Makefile features.in/Makefile +3 -0

No files found.
--- a/bin/check-recipe
+++ b/bin/check-recipe
+#!/bin/sh
+
+# missing "; @:" for recipeless rules makes SHELL payload useless
+# (see also ../lib/report.mk); this results in broken target graphs
+# (so REPORT=1 gets crippled)
+
+  sed 's/^[a-z]\+\/.*:.*$/\n&/' "$@" \
+| grep -vE '^(#|export|if|else|endif|define|endef)' \
+| sed ':loop /^[^#].*[^\\]\\$/N; s/\\\n//; t loop' \
+| grep -vE ':=| = | ?= | += |^\$' \
+| sed ':loop /^[a-z]\+\/.*:.*$/N; s/\n\t\+@*/\; /; t loop' \
+| grep -vE ';|^$' && exit 1 ||:
+
+# see also http://unix.stackexchange.com/questions/228547
--- a/conf.d/Makefile
+++ b/conf.d/Makefile
-# missing "; @:" for recipeless rules makes SHELL payload useless
-# (see also ../lib/report.mk); this results in broken target graphs
-# (so REPORT=1 gets crippled)
 check:
-	@grep -E '^[a-z]+/.*: .*[^\\:]$$' *.mk
+	@../bin/check-recipe *.mk
--- a/features.in/Makefile
+++ b/features.in/Makefile
@@ -25,6 +25,9 @@ define grepper_body
 	done
 endef

+check:
+	@../bin/check-recipe */config.mk
+
 %:
 	$(error BUILDDIR not defined)