Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
N
nx-libs
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
1
Issues
1
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
dimbor
nx-libs
Commits
1829a35c
You need to sign in or sign up before continuing.
Commit
1829a35c
authored
Sep 30, 2017
by
Mihai Moldovan
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
nxcomp/src/Log.h: block signals while writing out data.
Prevents race conditions caused by signal handlers while flushing out our log queue.
parent
09586d76
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
20 additions
and
0 deletions
+20
-0
Log.h
nxcomp/src/Log.h
+20
-0
No files found.
nxcomp/src/Log.h
View file @
1829a35c
...
...
@@ -35,6 +35,7 @@
#include <map>
#include <stdlib.h>
#include <string.h>
#include <signal.h>
#include <assert.h>
#include <stack>
...
...
@@ -218,6 +219,22 @@ class NXLog
*/
void
flush
(
per_thread_data
*
pdt
)
{
/*
* Block all signals until we are dong printing data.
* Ensures that a signal handler won't interrupt us
* and overwrite the buffer data mid-print, leading
* to confusing output.
*/
sigset_t
orig_signal_mask
,
tmp_signal_mask
;
sigemptyset
(
&
orig_signal_mask
);
/* Set up new mask to block all signals. */
sigfillset
(
&
tmp_signal_mask
);
/* Block all signals. */
pthread_sigmask
(
SIG_BLOCK
,
&
tmp_signal_mask
,
&
orig_signal_mask
);
if
(
!
pdt
->
buffer
.
empty
())
{
const
std
::
string
str
=
pdt
->
buffer
.
top
()
->
str
();
...
...
@@ -231,6 +248,9 @@ class NXLog
/* Remove from stack. */
pdt
->
buffer
.
pop
();
}
/* Restore old signal mask. */
pthread_sigmask
(
SIG_SETMASK
,
&
orig_signal_mask
,
NULL
);
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment