Commit 3cabdfa2 authored by Ulrich Sibiller's avatar Ulrich Sibiller Committed by Mike Gabriel

NXproperty.c: simplify and reformat GetWindowProperty()

parent 513418ac
...@@ -466,9 +466,6 @@ GetWindowProperty(pWin, property, longOffset, longLength, delete, ...@@ -466,9 +466,6 @@ GetWindowProperty(pWin, property, longOffset, longLength, delete,
unsigned long *bytesAfter; unsigned long *bytesAfter;
unsigned char **propData; unsigned char **propData;
{ {
PropertyPtr pProp, prevProp;
unsigned long n, len, ind;
if (!pWin) if (!pWin)
{ {
#ifdef DEBUG #ifdef DEBUG
...@@ -484,6 +481,7 @@ GetWindowProperty(pWin, property, longOffset, longLength, delete, ...@@ -484,6 +481,7 @@ GetWindowProperty(pWin, property, longOffset, longLength, delete,
#endif #endif
return BadAtom; return BadAtom;
} }
if ((type != AnyPropertyType) && !ValidAtom(type)) if ((type != AnyPropertyType) && !ValidAtom(type))
{ {
#ifdef DEBUG #ifdef DEBUG
...@@ -492,8 +490,8 @@ GetWindowProperty(pWin, property, longOffset, longLength, delete, ...@@ -492,8 +490,8 @@ GetWindowProperty(pWin, property, longOffset, longLength, delete,
return BadAtom; return BadAtom;
} }
pProp = wUserProps (pWin); PropertyPtr pProp = wUserProps (pWin);
prevProp = (PropertyPtr)NULL; PropertyPtr prevProp = (PropertyPtr)NULL;
while (pProp) while (pProp)
{ {
...@@ -522,14 +520,14 @@ GetWindowProperty(pWin, property, longOffset, longLength, delete, ...@@ -522,14 +520,14 @@ GetWindowProperty(pWin, property, longOffset, longLength, delete,
*format = pProp->format; *format = pProp->format;
*nItems = 0; *nItems = 0;
*actualType = pProp->type; *actualType = pProp->type;
return(Success); return Success;
} }
/* /*
* Return type, format, value to client * Return type, format, value to client
*/ */
n = (pProp->format/8) * pProp->size; /* size (bytes) of prop */ unsigned long n = (pProp->format/8) * pProp->size; /* size (bytes) of prop */
ind = longOffset << 2; unsigned long ind = longOffset << 2;
/* If longOffset is invalid such that it causes "len" to /* If longOffset is invalid such that it causes "len" to
be negative, it's a value error. */ be negative, it's a value error. */
...@@ -542,7 +540,7 @@ GetWindowProperty(pWin, property, longOffset, longLength, delete, ...@@ -542,7 +540,7 @@ GetWindowProperty(pWin, property, longOffset, longLength, delete,
return BadValue; return BadValue;
} }
len = min(n - ind, 4 * longLength); unsigned long len = min(n - ind, 4 * longLength);
*bytesAfter = n - (ind + len); *bytesAfter = n - (ind + len);
*format = pProp->format; *format = pProp->format;
...@@ -566,7 +564,7 @@ GetWindowProperty(pWin, property, longOffset, longLength, delete, ...@@ -566,7 +564,7 @@ GetWindowProperty(pWin, property, longOffset, longLength, delete,
} }
if (delete && (*bytesAfter == 0)) if (delete && (*bytesAfter == 0))
{ /* delete the Property */ { /* delete the property */
if (prevProp == (PropertyPtr)NULL) /* takes care of head */ if (prevProp == (PropertyPtr)NULL) /* takes care of head */
{ {
if (!(pWin->optional->userProps = pProp->next)) if (!(pWin->optional->userProps = pProp->next))
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment