Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
N
nx-libs
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
1
Issues
1
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
dimbor
nx-libs
Commits
4d95e29b
Commit
4d95e29b
authored
Jan 04, 2021
by
Ulrich Sibiller
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Window.c: check for malloc failure
PVS finding: "V522 There might be dereferencing of a potential null pointer 'props'"
parent
5ad0b4dd
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
22 additions
and
13 deletions
+22
-13
Window.c
nx-X11/programs/Xserver/hw/nxagent/Window.c
+22
-13
No files found.
nx-X11/programs/Xserver/hw/nxagent/Window.c
View file @
4d95e29b
...
...
@@ -3090,27 +3090,36 @@ static void nxagentReconnectWindow(void * param0, XID param1, void * data_buffer
(
void
*
)
pWin
,
pWin
->
drawable
.
id
,
nxagentWindow
(
pWin
));
#endif
/* FIXME: use XAllocSizeHints() */
#ifdef _XSERVER64
data64
=
(
unsigned
char
*
)
malloc
(
sizeof
(
XSizeHints
)
+
4
);
if
(
data64
)
{
for
(
int
i
=
0
;
i
<
4
;
i
++
)
{
*
(
data64
+
i
)
=
*
(
data
+
i
);
}
for
(
int
i
=
0
;
i
<
4
;
i
++
)
{
*
(
data64
+
i
)
=
*
(
data
+
i
);
}
*
(((
int
*
)
data64
)
+
1
)
=
0
;
*
(((
int
*
)
data64
)
+
1
)
=
0
;
for
(
int
i
=
8
;
i
<
sizeof
(
XSizeHints
)
+
4
;
i
++
)
{
*
(
data64
+
i
)
=
*
(
data
+
i
-
4
);
}
for
(
int
i
=
8
;
i
<
sizeof
(
XSizeHints
)
+
4
;
i
++
)
{
*
(
data64
+
i
)
=
*
(
data
+
i
-
4
);
}
XSizeHints
*
props
=
(
XSizeHints
*
)
data64
;
XSizeHints
*
props
=
(
XSizeHints
*
)
data64
;
#else
XSizeHints
*
props
=
(
XSizeHints
*
)
data
;
XSizeHints
*
props
=
(
XSizeHints
*
)
data
;
#endif
/* _XSERVER64 */
hints
=
*
props
;
hints
=
*
props
;
}
else
{
#ifdef WARNING
fprintf
(
stderr
,
"%s: Failed to alloc memory for XSizeHints
\n
"
,
__func__
);
#endif
}
}
else
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment