Skip to content

N
nx-libs
Commit 4d95e29b authored by Ulrich Sibiller's avatar Ulrich Sibiller
Browse files
Options

Window.c: check for malloc failure

PVS finding: "V522 There might be dereferencing of a potential null pointer 'props'"
parent 5ad0b4dd
Show whitespace changes
Inline Side-by-side
Showing with 10 additions and 1 deletion
nx-X11/programs/Xserver/hw/nxagent/Window.c
View file @ 4d95e29b
...@@ -3090,9 +3090,11 @@ static void nxagentReconnectWindow(void * param0, XID param1, void * data_buffer ...@@ -3090,9 +3090,11 @@ static void nxagentReconnectWindow(void * param0, XID param1, void * data_buffer
(void*)pWin, pWin -> drawable.id, nxagentWindow(pWin)); (void*)pWin, pWin -> drawable.id, nxagentWindow(pWin));
#endif #endif
/* FIXME: use XAllocSizeHints() */
#ifdef _XSERVER64 #ifdef _XSERVER64
data64 = (unsigned char *) malloc(sizeof(XSizeHints) + 4); data64 = (unsigned char *) malloc(sizeof(XSizeHints) + 4);
if (data64)
{
for (int i = 0; i < 4; i++) for (int i = 0; i < 4; i++)
{ {
*(data64 + i) = *(data + i); *(data64 + i) = *(data + i);
...@@ -3115,6 +3117,13 @@ static void nxagentReconnectWindow(void * param0, XID param1, void * data_buffer ...@@ -3115,6 +3117,13 @@ static void nxagentReconnectWindow(void * param0, XID param1, void * data_buffer
else else
{ {
#ifdef WARNING #ifdef WARNING
fprintf(stderr, "%s: Failed to alloc memory for XSizeHints\n", __func__);
#endif
}
}
else
{
#ifdef WARNING
fprintf(stderr, "nxagentReconnectWindow: Failed to get property WM_NORMAL_HINTS on window %p\n", fprintf(stderr, "nxagentReconnectWindow: Failed to get property WM_NORMAL_HINTS on window %p\n",
(void*)pWin); (void*)pWin);
#endif #endif
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment