Unverified Commit 796c8e42 authored by Mike Gabriel's avatar Mike Gabriel

Merge branch 'uli42-pr/drop_faulty_render_check' into 3.6.x

parents c577775f 5aee32e9
...@@ -95,13 +95,6 @@ ProcQueryExtension(ClientPtr client) ...@@ -95,13 +95,6 @@ ProcQueryExtension(ClientPtr client)
{ {
i = FindExtension((char *)&stuff[1], stuff->nbytes); i = FindExtension((char *)&stuff[1], stuff->nbytes);
if (i < 0 if (i < 0
/*
* Hide RENDER if our implementation
* is faulty.
*/
|| (nxagentRenderTrap && strcmp(extensions[i]->name, "RENDER") == 0)
#ifdef XCSECURITY #ifdef XCSECURITY
/* don't show insecure extensions to untrusted clients */ /* don't show insecure extensions to untrusted clients */
|| (client->trustLevel == XSecurityClientUntrusted && || (client->trustLevel == XSecurityClientUntrusted &&
...@@ -149,14 +142,6 @@ ProcListExtensions(ClientPtr client) ...@@ -149,14 +142,6 @@ ProcListExtensions(ClientPtr client)
!extensions[i]->secure) !extensions[i]->secure)
continue; continue;
#endif #endif
/*
* Hide RENDER if our implementation
* is faulty.
*/
if (nxagentRenderTrap && strcmp(extensions[i]->name, "RENDER") == 0)
continue;
total_length += strlen(extensions[i]->name) + 1; total_length += strlen(extensions[i]->name) + 1;
reply.nExtensions += 1 + extensions[i]->num_aliases; reply.nExtensions += 1 + extensions[i]->num_aliases;
for (j = extensions[i]->num_aliases; --j >= 0;) for (j = extensions[i]->num_aliases; --j >= 0;)
......
...@@ -1665,16 +1665,6 @@ ProcRenderDispatch (ClientPtr client) ...@@ -1665,16 +1665,6 @@ ProcRenderDispatch (ClientPtr client)
REQUEST(xReq); REQUEST(xReq);
/*
* Let the client fail if we are
* hiding the RENDER extension.
*/
if (nxagentRenderTrap)
{
return BadRequest;
}
if (stuff->data < RenderNumberRequests) if (stuff->data < RenderNumberRequests)
{ {
#ifdef TEST #ifdef TEST
...@@ -1707,16 +1697,6 @@ SProcRenderDispatch (ClientPtr client) ...@@ -1707,16 +1697,6 @@ SProcRenderDispatch (ClientPtr client)
REQUEST(xReq); REQUEST(xReq);
/*
* Let the client fail if we are
* hiding the RENDER extension.
*/
if (nxagentRenderTrap)
{
return BadRequest;
}
if (stuff->data < RenderNumberRequests) if (stuff->data < RenderNumberRequests)
{ {
/* /*
......
...@@ -322,41 +322,6 @@ PixmapPtr nxagentCreatePixmap(ScreenPtr pScreen, int width, int height, ...@@ -322,41 +322,6 @@ PixmapPtr nxagentCreatePixmap(ScreenPtr pScreen, int width, int height,
pVirtualPriv -> pVirtualPixmap = NULL; pVirtualPriv -> pVirtualPixmap = NULL;
pVirtualPriv -> pPicture = NULL; pVirtualPriv -> pPicture = NULL;
/*
* Check that the virtual pixmap is created with
* the appropriate bits-per-plane, otherwise free
* everything and return.
*/
if (pVirtual -> drawable.bitsPerPixel == 0)
{
#ifdef WARNING
fprintf(stderr, "nxagentCreatePixmap: WARNING! Virtual pixmap at [%p] has invalid "
"bits per pixel.\n", (void *) pVirtual);
fprintf(stderr, "nxagentCreatePixmap: WARNING! Real pixmap created with width [%d] "
"height [%d] depth [%d] bits per pixel [%d] and allocation hint [%d].\n",
pPixmap -> drawable.width,
pPixmap -> drawable.height = height, pPixmap -> drawable.depth,
pPixmap -> drawable.bitsPerPixel,
usage_hint);
#endif
if (!nxagentRenderTrap)
{
#ifdef WARNING
fprintf(stderr, "Warning: Disabling render extension due to missing pixmap format.\n");
#endif
nxagentRenderTrap = 1;
}
nxagentDestroyPixmap(pPixmap);
return NullPixmap;
}
#ifdef TEST #ifdef TEST
fprintf(stderr, "nxagentCreatePixmap: Created pixmap at [%p] virtual at [%p] with width [%d] " fprintf(stderr, "nxagentCreatePixmap: Created pixmap at [%p] virtual at [%p] with width [%d] "
"height [%d] depth [%d] and allocation hint [%d].\n", "height [%d] depth [%d] and allocation hint [%d].\n",
......
...@@ -42,13 +42,6 @@ int nxagentGCTrap = 0; ...@@ -42,13 +42,6 @@ int nxagentGCTrap = 0;
int nxagentScreenTrap = 0; int nxagentScreenTrap = 0;
/* /*
* Set if we detected that our RENDER
* implementation is faulty.
*/
int nxagentRenderTrap = 0;
/*
* Set if we are executing a GC operation * Set if we are executing a GC operation
* only on the X side. Used to avoid * only on the X side. Used to avoid
* reentrancy in FB layer. * reentrancy in FB layer.
......
...@@ -43,13 +43,6 @@ extern int nxagentGCTrap; ...@@ -43,13 +43,6 @@ extern int nxagentGCTrap;
extern int nxagentScreenTrap; extern int nxagentScreenTrap;
/* /*
* Set if we detected that our RENDER
* implementation is faulty.
*/
extern int nxagentRenderTrap;
/*
* Set if we are executing a GC operation * Set if we are executing a GC operation
* only on the X side. Used to avoid * only on the X side. Used to avoid
* reentrancy in FB layer. * reentrancy in FB layer.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment