Rootless.c: fix common realloc mistake

As reported by static analyzer: (error) Common realloc mistake: 'ptr' nulled but not freed upon failure Attributes ArcticaProject/nx-libs#905

Rootless.c: fix common realloc mistake
9b56675d · Ulrich Sibiller · Mike Gabriel · 434d5085 · 9b56675d
Commit 9b56675d authored Jan 25, 2020 by Ulrich Sibiller Committed by Mike Gabriel May 07, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 2 deletions

Rootless.c nx-X11/programs/Xserver/hw/nxagent/Rootless.c +1 -2

No files found.
--- a/nx-X11/programs/Xserver/hw/nxagent/Rootless.c
+++ b/nx-X11/programs/Xserver/hw/nxagent/Rootless.c
@@ -151,10 +151,9 @@ void nxagentRootlessAddTopLevelWindow(WindowPtr pWin, Window w)

  if (topLevelParentMap.next == topLevelParentMap.size)
  {
-    TopLevelParentRec *ptr = topLevelParentMap.elt;
    size_t size = (topLevelParentMap.size += TOP_LEVEL_TABLE_UNIT);

-    ptr = realloc(ptr, size * sizeof(TopLevelParentRec));
+    TopLevelParentRec *ptr = realloc(topLevelParentMap.elt, size * sizeof(TopLevelParentRec));

    if (ptr == NULL)
    {