Commit cb283d4a authored by Ulrich Sibiller's avatar Ulrich Sibiller

Keyboard.c: code simplification / scope improvements

parent 58415b56
...@@ -312,10 +312,7 @@ void nxagentChangeKeyboardControl(DeviceIntPtr pDev, KeybdCtrl *ctrl) ...@@ -312,10 +312,7 @@ void nxagentChangeKeyboardControl(DeviceIntPtr pDev, KeybdCtrl *ctrl)
fprintf(stderr, "%s: WARNING! Propagating changes to keyboard settings.\n", __func__); fprintf(stderr, "%s: WARNING! Propagating changes to keyboard settings.\n", __func__);
#endif #endif
unsigned long value_mask = KBKeyClickPercent | unsigned long value_mask = KBKeyClickPercent | KBBellPercent | KBBellPitch | KBBellDuration;
KBBellPercent |
KBBellPitch |
KBBellDuration;
XKeyboardControl values = { XKeyboardControl values = {
.key_click_percent = ctrl->click, .key_click_percent = ctrl->click,
...@@ -426,10 +423,9 @@ N/A ...@@ -426,10 +423,9 @@ N/A
#ifdef _XSERVER64 #ifdef _XSERVER64
{ {
KeySym64 *keymap64 = XGetKeyboardMapping(nxagentDisplay, KeySym64 *keymap64 = XGetKeyboardMapping(nxagentDisplay,
min_keycode, min_keycode,
max_keycode - min_keycode + 1, max_keycode - min_keycode + 1,
&mapWidth); &mapWidth);
if (keymap64 == NULL) if (keymap64 == NULL)
{ {
XFreeModifiermap(modifier_keymap); XFreeModifiermap(modifier_keymap);
...@@ -867,7 +863,6 @@ void nxagentNotifyKeyboardChanges(int oldMinKeycode, int oldMaxKeycode) ...@@ -867,7 +863,6 @@ void nxagentNotifyKeyboardChanges(int oldMinKeycode, int oldMaxKeycode)
#endif #endif
xEvent event = {0}; xEvent event = {0};
event.u.u.type = MappingNotify; event.u.u.type = MappingNotify;
event.u.mappingNotify.request = MappingKeyboard; event.u.mappingNotify.request = MappingKeyboard;
event.u.mappingNotify.firstKeyCode = inputInfo.keyboard -> key -> curKeySyms.minKeyCode; event.u.mappingNotify.firstKeyCode = inputInfo.keyboard -> key -> curKeySyms.minKeyCode;
...@@ -940,12 +935,11 @@ int nxagentResetKeyboard(void) ...@@ -940,12 +935,11 @@ int nxagentResetKeyboard(void)
} }
#endif #endif
dev->key=NULL; dev->key = NULL;
} }
dev->focus=NULL; dev->focus = NULL;
dev->kbdfeed = NULL;
dev->kbdfeed=NULL;
#ifdef XKB #ifdef XKB
nxagentTuneXkbWrapper(); nxagentTuneXkbWrapper();
...@@ -1091,37 +1085,37 @@ static int nxagentFreeKeyboardDeviceData(DeviceIntPtr dev) ...@@ -1091,37 +1085,37 @@ static int nxagentFreeKeyboardDeviceData(DeviceIntPtr dev)
if (dev->key) if (dev->key)
{ {
#ifdef XKB #ifdef XKB
if (noXkbExtension == 0 && dev->key->xkbInfo) if (noXkbExtension == 0 && dev->key->xkbInfo)
{ {
XkbFreeInfo(dev->key->xkbInfo); XkbFreeInfo(dev->key->xkbInfo);
dev->key->xkbInfo = NULL; dev->key->xkbInfo = NULL;
} }
#endif #endif
SAFE_free(dev->key->curKeySyms.map); SAFE_free(dev->key->curKeySyms.map);
SAFE_free(dev->key->modifierKeyMap); SAFE_free(dev->key->modifierKeyMap);
SAFE_free(dev->key); SAFE_free(dev->key);
} }
if (dev->focus) if (dev->focus)
{ {
SAFE_free(dev->focus->trace); SAFE_free(dev->focus->trace);
SAFE_free(dev->focus); SAFE_free(dev->focus);
} }
if (dev->kbdfeed) if (dev->kbdfeed)
{ {
for (KbdFeedbackPtr k = dev->kbdfeed, knext; k; k = knext) for (KbdFeedbackPtr k = dev->kbdfeed, knext; k; k = knext)
{ {
knext = k->next; knext = k->next;
#ifdef XKB #ifdef XKB
if (k->xkb_sli) if (k->xkb_sli)
XkbFreeSrvLedInfo(k->xkb_sli); XkbFreeSrvLedInfo(k->xkb_sli);
#endif #endif
SAFE_free(k); SAFE_free(k);
} }
dev->kbdfeed = NULL; dev->kbdfeed = NULL;
} }
#ifdef DEBUG #ifdef DEBUG
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment