Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
N
nx-libs
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
1
Issues
1
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
dimbor
nx-libs
Commits
d627e948
Commit
d627e948
authored
Jan 30, 2021
by
Ulrich Sibiller
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
NXproperty.c, dix.c: simplify ProcDeleteProperty()
by calling the dix version after a check
parent
b8b1edb2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
45 deletions
+9
-45
property.c
nx-X11/programs/Xserver/dix/property.c
+4
-2
NXproperty.c
nx-X11/programs/Xserver/hw/nxagent/NXproperty.c
+5
-43
No files found.
nx-X11/programs/Xserver/dix/property.c
View file @
d627e948
...
...
@@ -661,9 +661,12 @@ ProcListProperties(ClientPtr client)
return
(
client
->
noClientException
);
}
#ifndef NXAGENT_SERVER
int
#ifdef NXAGENT_SERVER
xorg_ProcDeleteProperty
(
register
ClientPtr
client
)
#else
ProcDeleteProperty
(
register
ClientPtr
client
)
#endif
{
WindowPtr
pWin
;
REQUEST
(
xDeletePropertyReq
);
...
...
@@ -699,4 +702,3 @@ ProcDeleteProperty(register ClientPtr client)
else
return
(
result
);
}
#endif
nx-X11/programs/Xserver/hw/nxagent/NXproperty.c
View file @
d627e948
...
...
@@ -180,11 +180,8 @@ ProcChangeProperty(ClientPtr client)
#ifdef NXAGENT_SERVER
/* prevent clients from changing the NX_AGENT_VERSION property */
{
Atom
prop
=
MakeAtom
(
"NX_AGENT_VERSION"
,
strlen
(
"NX_AGENT_VERSION"
),
True
);
if
(
stuff
->
property
==
prop
)
return
client
->
noClientException
;
}
if
(
stuff
->
property
==
MakeAtom
(
"NX_AGENT_VERSION"
,
strlen
(
"NX_AGENT_VERSION"
),
True
))
return
client
->
noClientException
;
#endif
err
=
ChangeWindowProperty
(
pWin
,
stuff
->
property
,
stuff
->
type
,
(
int
)
format
,
...
...
@@ -577,46 +574,11 @@ GetWindowProperty(WindowPtr pWin, Atom property, long longOffset,
int
ProcDeleteProperty
(
register
ClientPtr
client
)
{
WindowPtr
pWin
;
REQUEST
(
xDeletePropertyReq
);
int
result
;
REQUEST_SIZE_MATCH
(
xDeletePropertyReq
);
UpdateCurrentTime
();
pWin
=
(
WindowPtr
)
SecurityLookupWindow
(
stuff
->
window
,
client
,
DixWriteAccess
);
if
(
!
pWin
)
return
(
BadWindow
);
if
(
!
ValidAtom
(
stuff
->
property
))
{
client
->
errorValue
=
stuff
->
property
;
return
(
BadAtom
);
}
#ifdef XCSECURITY
switch
(
SecurityCheckPropertyAccess
(
client
,
pWin
,
stuff
->
property
,
DixDestroyAccess
))
{
case
SecurityErrorOperation
:
client
->
errorValue
=
stuff
->
property
;
return
BadAtom
;;
case
SecurityIgnoreOperation
:
return
Success
;
}
#endif
#ifdef NXAGENT_SERVER
/* prevent clients from deleting the NX_AGENT_VERSION property */
{
Atom
prop
=
MakeAtom
(
"NX_AGENT_VERSION"
,
strlen
(
"NX_AGENT_VERSION"
),
True
);
if
(
stuff
->
property
==
prop
)
return
client
->
noClientException
;
}
#endif
if
(
stuff
->
property
==
MakeAtom
(
"NX_AGENT_VERSION"
,
strlen
(
"NX_AGENT_VERSION"
),
True
))
return
client
->
noClientException
;
result
=
DeleteProperty
(
pWin
,
stuff
->
property
);
if
(
client
->
noClientException
!=
Success
)
return
(
client
->
noClientException
);
else
return
(
result
);
return
xorg_ProcDeleteProperty
(
client
);
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment