just as the rest of the Xserver is alsow doing

nxagentWindowTopLevel() and nxagentNeedConnectionChange() return Boolean
nxagentPixmapIsVirtual() and nxagentIsShmPixmap(), too.

They have been changed to tri-state variables (1, 0 and UNDEFINED)
between nxagent 1.5.0-90 and -93, for no obvious reason.

Many variables are used as Booleans. By adding the Bool define to
Options.h we can now make that visible.

and add the missing init code.

Adaptive, Composite, DeviceControl, DeviceControlUserDefined,
IgnoreVisibility, InhibitXkb, Nested, Menu, MagicPixel, Persistent,
Reset, ResetzKeyboardAtResume, SharedMemory, SharedPixmaps, Streaming,
UseDamage, ViewOnly, Xdmcp, Xinerama

The already where Booleans but where not using True/False values everywhere

There's no need/sense in having a tri-state with the third state being
UNDEFINED.

Fixes ArcticaProject/nx-libs#903

  Backported from X.org:

  From 446ff2d3177087b8173fa779fa5b77a2a128988b Mon Sep 17 00:00:00 2001
  From: Matthieu Herrb <matthieu@herrb.eu>
  Date: Thu, 12 Nov 2020 19:15:07 +0100
  Subject: [PATCH] Check SetMap request length carefully.

  Avoid out of bounds memory accesses on too short request.

  ZDI-CAN 11572 /  CVE-2020-14360

  This vulnerability was discovered by:
  Jan-Niklas Sohn working with Trend Micro Zero Day Initiative

  Fixes ArcticaProject/nx-libs#972.

Fixes ArcticaProject/nx-libs#983

causing DEBUG output in regular builds.

NXdixfonts.c: Regression fix for db45683a. Fix typo in libXfont1 function call (FreeFontName -> FreeFontNames). Fixes FTBFS on Ubuntu 14.04 and 16.04.

Attributes GH PR #963: https://github.com/ArcticaProject/nx-libs/pull/963

Attributes GH PR #961: https://github.com/ArcticaProject/nx-libs/pull/961
Approved by Ulrich Sibiller <uli42@gmx.de>, Tue, 03 Nov 2020 08:14:04 -0800

Fixes ArcticaProject/nx-libs#941

Png.c: In function ‘PngWriteData’:
Png.c:603:38: warning: declaration of ‘png_ptr’ shadows a global declaration [-Wshadow]
  603 | static void PngWriteData(png_structp png_ptr, png_bytep data, png_size_t length)
      |                          ~~~~~~~~~~~~^~~~~~~
Png.c:77:13: note: shadowed declaration is here
   77 | png_structp png_ptr;
      |             ^~~~~~~
Png.c: In function ‘PngFlushData’:
Png.c:610:38: warning: declaration of ‘png_ptr’ shadows a global declaration [-Wshadow]
  610 | static void PngFlushData(png_structp png_ptr)
      |                          ~~~~~~~~~~~~^~~~~~~
Png.c:77:13: note: shadowed declaration is here
   77 | png_structp png_ptr;
      |             ^~~~~~~

"warning: declaration of '<something>' shadows a member of 'this'

This shows up in gcc 4.8.5 and has been fixed in gcc 5.0, see
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57709

Change the variable names anyway to be on the safe side.

Fixes ArcticaProject/nx-libs#958

In file included from Proxy.h:39:0,
                 from ServerProxy.h:32,
                 from ServerProxy.cpp:36:
Channel.h: In member function 'int Channel::handleEncodeIdentity(EncodeBuffer&, ChannelCache*, MessageStore*, const unsigned char*, unsigned int, int)':
Channel.h:369:3: warning: declaration of 'bigEndian' shadows a member of 'this' [-Wshadow]
   {
   ^
Channel.h: In member function 'int Channel::handleDecodeIdentity(DecodeBuffer&, ChannelCache*, MessageStore*, unsigned char*&, unsigned int&, int, WriteBuffer*)':
Channel.h:378:3: warning: declaration of 'bigEndian' shadows a member of 'this' [-Wshadow]
   {
   ^

RHEL7's g++ 4.8.5 reports this while Debian's g++ 10.2.0-15 does
not. This is described in
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57709 and fixed in gcc
5.0.

Rename the variables anyway to be on the safe side.

Fixes ArcticaProject/nx-libs#956