sanitycheck.cgi 28.3 KB
Newer Older
1
#!/usr/bin/perl -wT
2
# -*- Mode: perl; indent-tabs-mode: nil -*-
3
#
4 5 6 7 8 9 10 11 12 13
# The contents of this file are subject to the Mozilla Public
# License Version 1.1 (the "License"); you may not use this file
# except in compliance with the License. You may obtain a copy of
# the License at http://www.mozilla.org/MPL/
#
# Software distributed under the License is distributed on an "AS
# IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
# implied. See the License for the specific language governing
# rights and limitations under the License.
#
14
# The Original Code is the Bugzilla Bug Tracking System.
15
#
16
# The Initial Developer of the Original Code is Netscape Communications
17 18 19 20
# Corporation. Portions created by Netscape are
# Copyright (C) 1998 Netscape Communications Corporation. All
# Rights Reserved.
#
21
# Contributor(s): Terry Weissman <terry@mozilla.org>
22
#                 Matthew Tuck <matty@chariot.net.au>
23
#                 Max Kanat-Alexander <mkanat@bugzilla.org>
24
#                 Marc Schumann <wurblzap@gmail.com>
25

26
use strict;
27

28 29
use lib qw(.);

30
require "globals.pl";
31
use Bugzilla::Constants;
32
use Bugzilla::User;
33

34 35 36
###########################################################################
# General subs
###########################################################################
37 38 39

sub Status {
    my ($str) = (@_);
40
    print "$str <p>\n";
41 42
}

43 44
sub Alert {
    my ($str) = (@_);
45
    Status("<font color=\"red\">$str</font>");
46 47
}

48 49
sub BugLink {
    my ($id) = (@_);
50
    return "<a href=\"show_bug.cgi?id=$id\">$id</a>";
51 52
}

53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69
#
# Parameter is a list of bug ids.
#
# Return is a string containing a list of all the bugids, as hrefs,
# followed by a link to them all as a buglist
sub BugListLinks {
    my @bugs = @_;

    # Historically, GetBugLink() wasn't used here. I'm guessing this
    # was because it didn't exist or is too performance heavy, or just
    # plain unnecessary
    my @bug_links = map(BugLink($_), @bugs);

    return join(', ',@bug_links) . " <a href=\"buglist.cgi?bug_id=" .
        join(',',@bugs) . "\">(as buglist)</a>";
}

70 71 72
###########################################################################
# Start
###########################################################################
73

74
Bugzilla->login(LOGIN_REQUIRED);
75

76
my $cgi = Bugzilla->cgi;
77
my $dbh = Bugzilla->dbh;
78
my $template = Bugzilla->template;
79

80 81 82 83 84 85 86 87
# Make sure the user is authorized to access sanitycheck.cgi.  Access
# is restricted to logged-in users who have "editbugs" privileges,
# which is a reasonable compromise between allowing all users to access
# the script (creating the potential for denial of service attacks)
# and restricting access to this installation's administrators (which
# prevents users with a legitimate interest in Bugzilla integrity
# from accessing the script).
UserInGroup("editbugs")
88 89 90
  || ThrowUserError("auth_failure", {group  => "editbugs",
                                     action => "run",
                                     object => "sanity_check"});
91

92
print $cgi->header();
93

94
my @row;
95

96
$template->put_header("Bugzilla Sanity Check");
97

98 99 100 101
###########################################################################
# Fix vote cache
###########################################################################

102
if (defined $cgi->param('rebuildvotecache')) {
103
    Status("OK, now rebuilding vote cache.");
104
    $dbh->bz_lock_tables('bugs WRITE', 'votes READ');
105
    SendSQL("UPDATE bugs SET votes = 0");
106 107
    SendSQL("SELECT bug_id, SUM(vote_count) FROM votes " .
            $dbh->sql_group_by('bug_id'));
108 109 110 111 112 113
    my %votes;
    while (@row = FetchSQLData()) {
        my ($id, $v) = (@row);
        $votes{$id} = $v;
    }
    foreach my $id (keys %votes) {
114
        SendSQL("UPDATE bugs SET votes = $votes{$id} WHERE bug_id = $id");
115
    }
116
    $dbh->bz_unlock_tables();
117
    Status("Vote cache has been rebuilt.");
118 119
}

120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188
###########################################################################
# Create missing group_control_map entries
###########################################################################

if (defined $cgi->param('createmissinggroupcontrolmapentries')) {
    Status(qq{OK, now creating <code>SHOWN</code> member control entries
              for product/group combinations lacking one.});

    my $na    = CONTROLMAPNA;
    my $shown = CONTROLMAPSHOWN;
    my $insertsth = $dbh->prepare(
        qq{INSERT INTO group_control_map (
                       group_id, product_id, entry,
                       membercontrol, othercontrol, canedit
                      )
               VALUES (
                       ?, ?, 0,
                       $shown, $na, 0
                      )});
    my $updatesth = $dbh->prepare(qq{UPDATE group_control_map
                                        SET membercontrol = $shown
                                      WHERE group_id   = ?
                                        AND product_id = ?});
    my $counter = 0;

    # Find all group/product combinations used for bugs but not set up
    # correctly in group_control_map
    my $invalid_combinations = $dbh->selectall_arrayref(
        qq{    SELECT bugs.product_id,
                      bgm.group_id,
                      gcm.membercontrol,
                      groups.name,
                      products.name
                 FROM bugs
           INNER JOIN bug_group_map AS bgm
                   ON bugs.bug_id = bgm.bug_id
           INNER JOIN groups
                   ON bgm.group_id = groups.id
           INNER JOIN products
                   ON bugs.product_id = products.id
            LEFT JOIN group_control_map AS gcm
                   ON bugs.product_id = gcm.product_id
                  AND    bgm.group_id = gcm.group_id
                WHERE COALESCE(gcm.membercontrol, $na) = $na
          } . $dbh->sql_group_by('bugs.product_id, bgm.group_id'));

    foreach (@$invalid_combinations) {
        my ($product_id, $group_id, $currentmembercontrol,
            $group_name, $product_name) = @$_;

        $counter++;
        if (defined($currentmembercontrol)) {
            Status(qq{Updating <code>NA/<em>xxx</em></code> group control
                      setting for group <em>$group_name</em> to
                      <code>SHOWN/<em>xxx</em></code> in product
                      <em>$product_name</em>.});
            $updatesth->execute($group_id, $product_id);
        }
        else {
            Status(qq{Generating <code>SHOWN/NA</code> group control setting
                      for group <em>$group_name</em> in product
                      <em>$product_name</em>.});
            $insertsth->execute($group_id, $product_id);
        }
    }

    Status("Repaired $counter defective group control settings.");
}

189 190 191 192
###########################################################################
# Send unsent mail
###########################################################################

193
if (defined $cgi->param('rescanallBugMail')) {
194 195 196
    require Bugzilla::BugMail;

    Status("OK, now attempting to send unsent mail");
197 198
    SendSQL("SELECT bug_id FROM bugs 
              WHERE (lastdiffed IS NULL OR lastdiffed < delta_ts) AND
199 200
             delta_ts < now() - " . $dbh->sql_interval('30 minute') .
            " ORDER BY bug_id");
201 202 203 204 205 206 207 208 209 210 211 212 213 214 215
    my @list;
    while (MoreSQLData()) {
        push (@list, FetchOneColumn());
    }

    Status(scalar(@list) . ' bugs found with possibly unsent mail.');

    foreach my $bugid (@list) {
        Bugzilla::BugMail::Send($bugid);
    }

    if (scalar(@list) > 0) {
        Status("Unsent mail has been sent.");
    }

216
    $template->put_footer();
217 218 219
    exit;
}

220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255
###########################################################################
# Remove all references to deleted bugs
###########################################################################

if (defined $cgi->param('remove_invalid_references')) {
    Status("OK, now removing all references to deleted bugs.");

    $dbh->bz_lock_tables('attachments WRITE', 'bug_group_map WRITE',
                         'bugs_activity WRITE', 'cc WRITE',
                         'dependencies WRITE', 'duplicates WRITE',
                         'flags WRITE', 'keywords WRITE',
                         'longdescs WRITE', 'votes WRITE', 'bugs READ');

    foreach my $pair ('attachments/', 'bug_group_map/', 'bugs_activity/', 'cc/',
                      'dependencies/blocked', 'dependencies/dependson',
                      'duplicates/dupe', 'duplicates/dupe_of',
                      'flags/', 'keywords/', 'longdescs/', 'votes/') {

        my ($table, $field) = split('/', $pair);
        $field ||= "bug_id";

        my $bug_ids =
          $dbh->selectcol_arrayref("SELECT $table.$field FROM $table
                                    LEFT JOIN bugs ON $table.$field = bugs.bug_id
                                    WHERE bugs.bug_id IS NULL");

        if (scalar(@$bug_ids)) {
            $dbh->do("DELETE FROM $table WHERE $field IN (" . join(',', @$bug_ids) . ")");
        }
    }

    $dbh->bz_unlock_tables();
    Status("All references to deleted bugs have been removed.");
}


256
print "OK, now running sanity checks.<p>\n";
257

258 259 260 261
###########################################################################
# Perform referential (cross) checks
###########################################################################

262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277
# This checks that a simple foreign key has a valid primary key value.  NULL
# references are acceptable and cause no problem.
#
# The first parameter is the primary key table name.
# The second parameter is the primary key field name.
# Each successive parameter represents a foreign key, it must be a list
# reference, where the list has:
#   the first value is the foreign key table name.
#   the second value is the foreign key field name.
#   the third value is optional and represents a field on the foreign key
#     table to display when the check fails.
#   the fourth value is optional and is a list reference to values that
#     are excluded from checking.
#
# FIXME: The excluded values parameter should go away - the QA contact
#        fields should use NULL instead - see bug #109474.
278
#        The same goes for series; no bug for that yet.
279

280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300
sub CrossCheck {
    my $table = shift @_;
    my $field = shift @_;

    Status("Checking references to $table.$field");

    while (@_) {
        my $ref = shift @_;
        my ($refertable, $referfield, $keyname, $exceptions) = @$ref;

        $exceptions ||= [];
        my %exceptions = map { $_ => 1 } @$exceptions;

        Status("... from $refertable.$referfield");
        
        SendSQL("SELECT DISTINCT $refertable.$referfield" . ($keyname ? ", $refertable.$keyname" : '') . " " .
                "FROM   $refertable LEFT JOIN $table " .
                "  ON   $refertable.$referfield = $table.$field " .
                "WHERE  $table.$field IS NULL " .
                "  AND  $refertable.$referfield IS NOT NULL");

301
        my $has_bad_references = 0;
302 303 304 305 306 307 308 309 310 311 312 313 314
        while (MoreSQLData()) {
            my ($value, $key) = FetchSQLData();
            if (!$exceptions{$value}) {
                my $alert = "Bad value $value found in $refertable.$referfield";
                if ($keyname) {
                    if ($keyname eq 'bug_id') {
                        $alert .= ' (bug ' . BugLink($key) . ')';
                    }
                    else {
                        $alert .= " ($keyname == '$key')";
                    }
                }
                Alert($alert);
315
                $has_bad_references = 1;
316 317
            }
        }
318 319 320 321
        # References to non existent bugs can be safely removed, bug 288461
        if ($table eq 'bugs' && $has_bad_references) {
            print qq{<a href="sanitycheck.cgi?remove_invalid_references=1">Remove invalid references to non existent bugs.</a><p>\n};
        }
322 323 324
    }
}

325 326 327
CrossCheck('classifications', 'id',
           ['products', 'classification_id']);

328 329 330 331
CrossCheck("keyworddefs", "id",
           ["keywords", "keywordid"]);

CrossCheck("fielddefs", "fieldid",
332 333
           ["bugs_activity", "fieldid"],
           ['profiles_activity', 'fieldid']);
334

335 336
CrossCheck("flagtypes", "id",
           ["flags", "type_id"]);
337 338 339

CrossCheck("bugs", "bug_id",
           ["bugs_activity", "bug_id"],
340
           ["bug_group_map", "bug_id"],
341 342 343 344 345
           ["attachments", "bug_id"],
           ["cc", "bug_id"],
           ["longdescs", "bug_id"],
           ["dependencies", "blocked"],
           ["dependencies", "dependson"],
346
           ['flags', 'bug_id'],
347
           ["votes", "bug_id"],
348 349 350
           ["keywords", "bug_id"],
           ["duplicates", "dupe_of", "dupe"],
           ["duplicates", "dupe", "dupe_of"]);
351

352 353
CrossCheck("groups", "id",
           ["bug_group_map", "group_id"],
354
           ['category_group_map', 'group_id'],
355 356
           ["group_group_map", "grantor_id"],
           ["group_group_map", "member_id"],
357
           ["group_control_map", "group_id"],
358 359
           ["user_group_map", "group_id"]);

360
CrossCheck("profiles", "userid",
361 362
           ['profiles_activity', 'userid'],
           ['profiles_activity', 'who'],
363 364
           ["bugs", "reporter", "bug_id"],
           ["bugs", "assigned_to", "bug_id"],
365
           ["bugs", "qa_contact", "bug_id"],
366
           ["attachments", "submitter_id", "bug_id"],
367 368
           ['flags', 'setter_id', 'bug_id'],
           ['flags', 'requestee_id', 'bug_id'],
369 370
           ["bugs_activity", "who", "bug_id"],
           ["cc", "who", "bug_id"],
371
           ['quips', 'userid'],
372 373
           ["votes", "who", "bug_id"],
           ["longdescs", "who", "bug_id"],
374
           ["logincookies", "userid"],
375
           ["namedqueries", "userid"],
376
           ['series', 'creator', 'series_id', ['0']],
377 378
           ["watch", "watcher"],
           ["watch", "watched"],
379
           ['whine_events', 'owner_userid'],
380
           ["tokens", "userid"],
381
           ["user_group_map", "user_id"],
382
           ["components", "initialowner", "name"],
383
           ["components", "initialqacontact", "name"]);
384

385 386 387 388 389
CrossCheck("products", "id",
           ["bugs", "product_id", "bug_id"],
           ["components", "product_id", "name"],
           ["milestones", "product_id", "value"],
           ["versions", "product_id", "value"],
390
           ["group_control_map", "product_id"],
391 392
           ["flaginclusions", "product_id", "type_id"],
           ["flagexclusions", "product_id", "type_id"]);
393

394
# Check the former enum types -mkanat@bugzilla.org
395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412
CrossCheck("bug_status", "value",
            ["bugs", "bug_status"]);

CrossCheck("resolution", "value",
            ["bugs", "resolution"]);

CrossCheck("bug_severity", "value",
            ["bugs", "bug_severity"]);

CrossCheck("op_sys", "value",
            ["bugs", "op_sys"]);

CrossCheck("priority", "value",
            ["bugs", "priority"]);

CrossCheck("rep_platform", "value",
            ["bugs", "rep_platform"]);

413 414 415 416 417 418 419 420 421 422
CrossCheck('series', 'series_id',
           ['series_data', 'series_id']);

CrossCheck('series_categories', 'id',
           ['series', 'category']);

CrossCheck('whine_events', 'id',
           ['whine_queries', 'eventid'],
           ['whine_schedules', 'eventid']);

423
###########################################################################
424
# Perform double field referential (cross) checks
425
###########################################################################
426
 
427 428 429 430 431 432 433 434 435 436 437 438 439 440
# This checks that a compound two-field foreign key has a valid primary key
# value.  NULL references are acceptable and cause no problem.
#
# The first parameter is the primary key table name.
# The second parameter is the primary key first field name.
# The third parameter is the primary key second field name.
# Each successive parameter represents a foreign key, it must be a list
# reference, where the list has:
#   the first value is the foreign key table name
#   the second value is the foreign key first field name.
#   the third value is the foreign key second field name.
#   the fourth value is optional and represents a field on the foreign key
#     table to display when the check fails

441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477
sub DoubleCrossCheck {
    my $table = shift @_;
    my $field1 = shift @_;
    my $field2 = shift @_;
 
    Status("Checking references to $table.$field1 / $table.$field2");
 
    while (@_) {
        my $ref = shift @_;
        my ($refertable, $referfield1, $referfield2, $keyname) = @$ref;
 
        Status("... from $refertable.$referfield1 / $refertable.$referfield2");
        
        SendSQL("SELECT DISTINCT $refertable.$referfield1, $refertable.$referfield2" . ($keyname ? ", $refertable.$keyname" : '') . " " .
                "FROM   $refertable LEFT JOIN $table " .
                "  ON   $refertable.$referfield1 = $table.$field1 " .
                " AND   $refertable.$referfield2 = $table.$field2 " .
                "WHERE  $table.$field1 IS NULL " .
                "  AND  $table.$field2 IS NULL " .
                "  AND  $refertable.$referfield1 IS NOT NULL " .
                "  AND  $refertable.$referfield2 IS NOT NULL");
 
        while (MoreSQLData()) {
            my ($value1, $value2, $key) = FetchSQLData();
 
            my $alert = "Bad values $value1, $value2 found in " .
                "$refertable.$referfield1 / $refertable.$referfield2";
            if ($keyname) {
                if ($keyname eq 'bug_id') {
                   $alert .= ' (bug ' . BugLink($key) . ')';
                }
                else {
                    $alert .= " ($keyname == '$key')";
                }
            }
            Alert($alert);
        }
478 479 480
    }
}

481 482 483 484
DoubleCrossCheck('attachments', 'bug_id', 'attach_id',
                 ['flags', 'bug_id', 'attach_id'],
                 ['bugs_activity', 'bug_id', 'attach_id']);

485
DoubleCrossCheck("components", "product_id", "id",
486 487 488
                 ["bugs", "product_id", "component_id", "bug_id"],
                 ['flagexclusions', 'product_id', 'component_id'],
                 ['flaginclusions', 'product_id', 'component_id']);
489

490 491 492 493 494 495
DoubleCrossCheck("versions", "product_id", "value",
                 ["bugs", "product_id", "version", "bug_id"]);
 
DoubleCrossCheck("milestones", "product_id", "value",
                 ["bugs", "product_id", "target_milestone", "bug_id"],
                 ["products", "id", "defaultmilestone", "name"]);
496

497 498 499 500
###########################################################################
# Perform login checks
###########################################################################
 
501
Status("Checking profile logins");
502

503
my $emailregexp = Param("emailregexp");
504
SendSQL("SELECT userid, login_name FROM profiles");
505

506
while (my ($id,$email) = (FetchSQLData())) {
507 508 509
    unless ($email =~ m/$emailregexp/) {
        Alert "Bad profile email address, id=$id,  &lt;$email&gt;."
    }
510
}
511

512 513 514
###########################################################################
# Perform vote/keyword cache checks
###########################################################################
515

516 517 518 519 520 521 522 523
my $offervotecacherebuild = 0;

sub AlertBadVoteCache {
    my ($id) = (@_);
    Alert("Bad vote cache for bug " . BugLink($id));
    $offervotecacherebuild = 1;
}

524
SendSQL("SELECT bug_id, votes, keywords FROM bugs " .
525
        "WHERE votes != 0 OR keywords != ''");
526

527
my %votes;
528
my %bugid;
529
my %keyword;
530 531

while (@row = FetchSQLData()) {
532
    my($id, $v, $k) = (@row);
533 534 535
    if ($v != 0) {
        $votes{$id} = $v;
    }
536 537 538
    if ($k) {
        $keyword{$id} = $k;
    }
539 540 541
}

Status("Checking cached vote counts");
542 543
SendSQL("SELECT bug_id, SUM(vote_count) FROM votes " .
        $dbh->sql_group_by('bug_id'));
544 545 546 547 548 549 550 551 552 553 554 555 556 557

while (@row = FetchSQLData()) {
    my ($id, $v) = (@row);
    if ($v <= 0) {
        Alert("Bad vote sum for bug $id");
    } else {
        if (!defined $votes{$id} || $votes{$id} != $v) {
            AlertBadVoteCache($id);
        }
        delete $votes{$id};
    }
}
foreach my $id (keys %votes) {
    AlertBadVoteCache($id);
558 559
}

560 561 562 563 564
if ($offervotecacherebuild) {
    print qq{<a href="sanitycheck.cgi?rebuildvotecache=1">Click here to rebuild the vote cache</a><p>\n};
}


565 566 567 568 569 570 571 572 573 574
Status("Checking keywords table");

my %keywordids;
SendSQL("SELECT id, name FROM keyworddefs");
while (@row = FetchSQLData()) {
    my ($id, $name) = (@row);
    if ($keywordids{$id}) {
        Alert("Duplicate entry in keyworddefs for id $id");
    }
    $keywordids{$id} = 1;
575
    if ($name =~ /[\s,]/) {
576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599
        Alert("Bogus name in keyworddefs for id $id");
    }
}


SendSQL("SELECT bug_id, keywordid FROM keywords ORDER BY bug_id, keywordid");
my $lastid;
my $lastk;
while (@row = FetchSQLData()) {
    my ($id, $k) = (@row);
    if (!$keywordids{$k}) {
        Alert("Bogus keywordids $k found in keywords table");
    }
    if (defined $lastid && $id eq $lastid && $k eq $lastk) {
        Alert("Duplicate keyword ids found in bug " . BugLink($id));
    }
    $lastid = $id;
    $lastk = $k;
}

Status("Checking cached keywords");

my %realk;

600
if (defined $cgi->param('rebuildkeywordcache')) {
601 602
    $dbh->bz_lock_tables('bugs write', 'keywords read',
                                  'keyworddefs read');
603 604 605
}

SendSQL("SELECT keywords.bug_id, keyworddefs.name " .
606 607 608 609 610
        "FROM keywords " .
        "INNER JOIN keyworddefs " .
        "   ON keyworddefs.id = keywords.keywordid " .
        "INNER JOIN bugs " .
        "   ON keywords.bug_id = bugs.bug_id " .
611 612
        "ORDER BY keywords.bug_id, keyworddefs.name");

613
my $lastb = 0;
614 615
my @list;
while (1) {
616
    my ($b, $k) = FetchSQLData();
617
    if (!defined $b || $b != $lastb) {
618 619 620 621 622 623 624 625 626 627 628 629
        if (@list) {
            $realk{$lastb} = join(', ', @list);
        }
        if (!$b) {
            last;
        }
        $lastb = $b;
        @list = ();
    }
    push(@list, $k);
}

630
my @badbugs = ();
631

632 633
foreach my $b (keys(%keyword)) {
    if (!exists $realk{$b} || $realk{$b} ne $keyword{$b}) {
634
        push(@badbugs, $b);
635 636 637 638
    }
}
foreach my $b (keys(%realk)) {
    if (!exists $keyword{$b}) {
639
        push(@badbugs, $b);
640 641
    }
}
642 643
if (@badbugs) {
    @badbugs = sort {$a <=> $b} @badbugs;
644 645
    Alert(scalar(@badbugs) . " bug(s) found with incorrect keyword cache: " .
          BugListLinks(@badbugs));
646
    if (defined $cgi->param('rebuildkeywordcache')) {
647
        Status("OK, now fixing keyword cache.");
648
        foreach my $b (@badbugs) {
649 650 651 652
            my $k = '';
            if (exists($realk{$b})) {
                $k = $realk{$b};
            }
653
            SendSQL("UPDATE bugs SET keywords = " . SqlQuote($k) .
654 655 656 657 658 659 660 661
                    " WHERE bug_id = $b");
        }
        Status("Keyword cache fixed.");
    } else {
        print qq{<a href="sanitycheck.cgi?rebuildkeywordcache=1">Click here to rebuild the keyword cache</a><p>\n};
    }
}

662
if (defined $cgi->param('rebuildkeywordcache')) {
663
    $dbh->bz_unlock_tables();
664
}
665

666
###########################################################################
667
# General bug checks
668 669
###########################################################################

670
sub BugCheck {
671
    my ($middlesql, $errortext, $repairparam, $repairtext) = @_;
672 673 674 675 676 677 678 679 680 681 682
    
    SendSQL("SELECT DISTINCT bugs.bug_id " .
            "FROM $middlesql " .
            "ORDER BY bugs.bug_id");
    
    my @badbugs = ();
    
    while (@row = FetchSQLData()) {
        my ($id) = (@row);
        push (@badbugs, $id);
    }
683

684
    if (@badbugs) {
685
        Alert("$errortext: " . BugListLinks(@badbugs));
686 687 688 689 690
        if ($repairparam) {
            $repairtext ||= 'Repair these bugs';
            print qq{<a href="sanitycheck.cgi?$repairparam=1">$repairtext</a>.},
                  '<p>';
        }
691
    }
692 693
}

694
Status("Checking resolution/duplicates");
695

696 697
BugCheck("bugs INNER JOIN duplicates ON bugs.bug_id = duplicates.dupe " .
         "WHERE bugs.resolution != 'DUPLICATE'",
698
         "Bug(s) found on duplicates table that are not marked duplicate");
699

700 701 702 703
BugCheck("bugs LEFT JOIN duplicates ON bugs.bug_id = duplicates.dupe WHERE " .
         "bugs.resolution = 'DUPLICATE' AND " .
         "duplicates.dupe IS NULL",
         "Bug(s) found marked resolved duplicate and not on duplicates table");
704 705 706 707 708 709

Status("Checking statuses/resolutions");

my @open_states = map(SqlQuote($_), OpenStates());
my $open_states = join(', ', @open_states);

710 711 712 713
BugCheck("bugs WHERE bug_status IN ($open_states) AND resolution != ''",
         "Bugs with open status and a resolution");
BugCheck("bugs WHERE bug_status NOT IN ($open_states) AND resolution = ''",
         "Bugs with non-open status and no resolution");
714 715 716

Status("Checking statuses/everconfirmed");

717
BugCheck("bugs WHERE bug_status = 'UNCONFIRMED' AND everconfirmed = 1",
718 719 720
         "Bugs that are UNCONFIRMED but have everconfirmed set");
# The below list of resolutions is hardcoded because we don't know if future
# resolutions will be confirmed, unconfirmed or maybeconfirmed.  I suspect
721
# they will be maybeconfirmed, e.g. ASLEEP and REMIND.  This hardcoding should
722 723 724
# disappear when we have customised statuses.
BugCheck("bugs WHERE bug_status IN ('NEW', 'ASSIGNED', 'REOPENED') AND everconfirmed = 0",
         "Bugs with confirmed status but don't have everconfirmed set"); 
725 726 727

Status("Checking votes/everconfirmed");

728 729
BugCheck("bugs INNER JOIN products ON bugs.product_id = products.id " .
         "WHERE everconfirmed = 0 AND votestoconfirm <= votes",
730
         "Bugs that have enough votes to be confirmed but haven't been");
731

732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749
###########################################################################
# Date checks
###########################################################################

sub DateCheck {
    my $table = shift @_;
    my $field = shift @_;
    Status("Checking dates in $table.$field");
    SendSQL("SELECT COUNT( $field ) FROM $table WHERE $field > NOW()");
    my $c = FetchOneColumn();
    if ($c) {
        Alert("Found $c dates in future");
    }
}
    
DateCheck("groups", "last_changed");
DateCheck("profiles", "refreshed_when");

750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773
###########################################################################
# Control Values
###########################################################################

# Checks for values that are invalid OR
# not among the 9 valid combinations
Status("Checking for bad values in group_control_map");
SendSQL("SELECT COUNT(product_id) FROM group_control_map WHERE " .
        "membercontrol NOT IN(" . CONTROLMAPNA . "," . CONTROLMAPSHOWN .
        "," . CONTROLMAPDEFAULT . "," . CONTROLMAPMANDATORY . ")" .
        " OR " .
        "othercontrol NOT IN(" . CONTROLMAPNA . "," . CONTROLMAPSHOWN .
        "," . CONTROLMAPDEFAULT . "," . CONTROLMAPMANDATORY . ")" .
        " OR " .
        "( (membercontrol != othercontrol) " .
          "AND (membercontrol != " . CONTROLMAPSHOWN . ") " .
          "AND ((membercontrol != " . CONTROLMAPDEFAULT . ") " .
            "OR (othercontrol = " . CONTROLMAPSHOWN . ")))");
my $c = FetchOneColumn();
if ($c) {
    Alert("Found $c bad group_control_map entries");
}

Status("Checking for bugs with groups violating their product's group controls");
774
BugCheck("bugs
775 776 777 778
         INNER JOIN bug_group_map
            ON bugs.bug_id = bug_group_map.bug_id
          LEFT JOIN group_control_map
            ON bugs.product_id = group_control_map.product_id
779
           AND bug_group_map.group_id = group_control_map.group_id
780
         WHERE ((group_control_map.membercontrol = " . CONTROLMAPNA . ")
781
         OR (group_control_map.membercontrol IS NULL))",
782 783 784 785
         'Have groups not permitted for their products',
         'createmissinggroupcontrolmapentries',
         'Permit the missing groups for the affected products
          (set member control to <code>SHOWN</code>)');
786

787
BugCheck("bugs
788
         INNER JOIN group_control_map
789
            ON bugs.product_id = group_control_map.product_id
790 791 792 793 794
         INNER JOIN groups
            ON group_control_map.group_id = groups.id
          LEFT JOIN bug_group_map
            ON bugs.bug_id = bug_group_map.bug_id
           AND group_control_map.group_id = bug_group_map.group_id
795
         WHERE group_control_map.membercontrol = " . CONTROLMAPMANDATORY . "
796 797
           AND bug_group_map.group_id IS NULL
           AND groups.isactive != 0",
798 799 800
         "Are missing groups required for their products");


801 802 803 804 805 806 807 808 809
###########################################################################
# Unsent mail
###########################################################################

Status("Checking for unsent mail");

@badbugs = ();

SendSQL("SELECT bug_id " .
810
        "FROM bugs WHERE (lastdiffed IS NULL OR lastdiffed < delta_ts) AND " .
811 812
        "delta_ts < now() - " . $dbh->sql_interval('30 minute') .
        " ORDER BY bug_id");
813 814 815 816 817 818 819 820

while (@row = FetchSQLData()) {
    my ($id) = (@row);
    push(@badbugs, $id);
}

if (@badbugs > 0) {
    Alert("Bugs that have changes but no mail sent for at least half an hour: " .
821 822
          BugListLinks(@badbugs));

823
    print qq{<a href="sanitycheck.cgi?rescanallBugMail=1">Send these mails</a>.<p>\n};
824 825
}

826 827 828
###########################################################################
# End
###########################################################################
829 830

Status("Sanity check completed.");
831
$template->put_footer();