Common.pm 14.1 KB
Newer Older
1 2 3
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
4
#
5 6
# This Source Code Form is "Incompatible With Secondary Licenses", as
# defined by the Mozilla Public License, v. 2.0.
7 8 9

package Bugzilla::Config::Common;

10
use 5.10.1;
11 12
use strict;

13
use Email::Address;
14 15 16 17
use Socket;

use Bugzilla::Util;
use Bugzilla::Constants;
18
use Bugzilla::Field;
19
use Bugzilla::Group;
20
use Bugzilla::Status;
21 22 23

use base qw(Exporter);
@Bugzilla::Config::Common::EXPORT =
24
    qw(check_multi check_numeric check_regexp check_url check_group
25
       check_sslbase check_priority check_severity check_platform
26
       check_opsys check_shadowdb check_urlbase check_webdotbase
27
       check_user_verify_class check_ip
28
       check_mail_delivery_method check_notification check_utf8
29
       check_bug_status check_smtp_auth check_theschwartz_available
30
       check_maxattachmentsize check_email check_smtp_ssl
31 32 33 34 35 36 37 38 39 40 41 42 43 44
);

# Checking functions for the various values

sub check_multi {
    my ($value, $param) = (@_);

    if ($param->{'type'} eq "s") {
        unless (scalar(grep {$_ eq $value} (@{$param->{'choices'}}))) {
            return "Invalid choice '$value' for single-select list param '$param->{'name'}'";
        }

        return "";
    }
45 46
    elsif ($param->{'type'} eq 'm' || $param->{'type'} eq 'o') {
        foreach my $chkParam (split(',', $value)) {
47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73
            unless (scalar(grep {$_ eq $chkParam} (@{$param->{'choices'}}))) {
                return "Invalid choice '$chkParam' for multi-select list param '$param->{'name'}'";
            }
        }

        return "";
    }
    else {
        return "Invalid param type '$param->{'type'}' for check_multi(); " .
          "contact your Bugzilla administrator";
    }
}

sub check_numeric {
    my ($value) = (@_);
    if ($value !~ /^[0-9]+$/) {
        return "must be a numeric value";
    }
    return "";
}

sub check_regexp {
    my ($value) = (@_);
    eval { qr/$value/ };
    return $@;
}

74 75 76 77 78 79 80 81
sub check_email {
    my ($value) = @_;
    if ($value !~ $Email::Address::mailbox) {
        return "must be a valid email address.";
    }
    return "";
}

82 83 84 85 86 87 88
sub check_sslbase {
    my $url = shift;
    if ($url ne '') {
        if ($url !~ m#^https://([^/]+).*/$#) {
            return "must be a legal URL, that starts with https and ends with a slash.";
        }
        my $host = $1;
89 90 91 92 93
        # Fall back to port 443 if for some reason getservbyname() fails.
        my $port = getservbyname('https', 'tcp') || 443;
        if ($host =~ /^(.+):(\d+)$/) {
            $host = $1;
            $port = $2;
94 95 96 97
        }
        local *SOCK;
        my $proto = getprotobyname('tcp');
        socket(SOCK, PF_INET, SOCK_STREAM, $proto);
98 99
        my $iaddr = inet_aton($host) || return "The host $host cannot be resolved";
        my $sin = sockaddr_in($port, $iaddr);
100
        if (!connect(SOCK, $sin)) {
101
            return "Failed to connect to $host:$port; unable to enable SSL";
102
        }
103
        close(SOCK);
104 105
    }
    return "";
106 107
}

108 109 110 111 112 113 114 115 116
sub check_ip {
    my $inbound_proxies = shift;
    my @proxies = split(/[\s,]+/, $inbound_proxies);
    foreach my $proxy (@proxies) {
        validate_ip($proxy) || return "$proxy is not a valid IPv4 or IPv6 address";
    }
    return "";
}

117 118 119 120 121 122 123 124 125 126
sub check_utf8 {
    my $utf8 = shift;
    # You cannot turn off the UTF-8 parameter if you've already converted
    # your tables to utf-8.
    my $dbh = Bugzilla->dbh;
    if ($dbh->isa('Bugzilla::DB::Mysql') && $dbh->bz_db_is_utf8 && !$utf8) {
        return "You cannot disable UTF-8 support, because your MySQL database"
               . " is encoded in UTF-8";
    }
    return "";
127 128 129 130
}

sub check_priority {
    my ($value) = (@_);
131
    my $legal_priorities = get_legal_field_values('priority');
132
    if (!grep($_ eq $value, @$legal_priorities)) {
133
        return "Must be a legal priority value: one of " .
134
            join(", ", @$legal_priorities);
135 136 137 138 139 140
    }
    return "";
}

sub check_severity {
    my ($value) = (@_);
141
    my $legal_severities = get_legal_field_values('bug_severity');
142
    if (!grep($_ eq $value, @$legal_severities)) {
143
        return "Must be a legal severity value: one of " .
144
            join(", ", @$legal_severities);
145 146 147 148 149 150
    }
    return "";
}

sub check_platform {
    my ($value) = (@_);
151
    my $legal_platforms = get_legal_field_values('rep_platform');
152
    if (!grep($_ eq $value, '', @$legal_platforms)) {
153
        return "Must be empty or a legal platform value: one of " .
154
            join(", ", @$legal_platforms);
155 156 157 158 159 160
    }
    return "";
}

sub check_opsys {
    my ($value) = (@_);
161
    my $legal_OS = get_legal_field_values('op_sys');
162
    if (!grep($_ eq $value, '', @$legal_OS)) {
163
        return "Must be empty or a legal operating system value: one of " .
164
            join(", ", @$legal_OS);
165 166 167 168
    }
    return "";
}

169 170
sub check_bug_status {
    my $bug_status = shift;
171
    my @closed_bug_statuses = map {$_->name} closed_bug_statuses();
172
    if (!grep($_ eq $bug_status, @closed_bug_statuses)) {
173 174 175 176 177
        return "Must be a valid closed status: one of " . join(', ', @closed_bug_statuses);
    }
    return "";
}

178 179
sub check_group {
    my $group_name = shift;
180
    return "" unless $group_name;
181 182 183 184 185 186 187
    my $group = new Bugzilla::Group({'name' => $group_name});
    unless (defined $group) {
        return "Must be an existing group name";
    }
    return "";
}

188 189 190 191 192 193 194
sub check_shadowdb {
    my ($value) = (@_);
    $value = trim($value);
    if ($value eq "") {
        return "";
    }

195
    if (!Bugzilla->params->{'shadowdbhost'}) {
196 197 198 199 200 201 202 203 204 205 206
        return "You need to specify a host when using a shadow database";
    }

    # Can't test existence of this because ConnectToDatabase uses the param,
    # but we can't set this before testing....
    # This can really only be fixed after we can use the DBI more openly
    return "";
}

sub check_urlbase {
    my ($url) = (@_);
207
    if ($url && $url !~ m:^http.*/$:) {
208 209 210 211 212
        return "must be a legal URL, that starts with http and ends with a slash.";
    }
    return "";
}

213 214 215 216 217 218 219 220 221
sub check_url {
    my ($url) = (@_);
    return '' if $url eq ''; # Allow empty URLs
    if ($url !~ m:/$:) {
        return 'must be a legal URL, absolute or relative, ending with a slash.';
    }
    return '';
}

222 223 224 225 226 227 228 229 230 231 232
sub check_webdotbase {
    my ($value) = (@_);
    $value = trim($value);
    if ($value eq "") {
        return "";
    }
    if($value !~ /^https?:/) {
        if(! -x $value) {
            return "The file path \"$value\" is not a valid executable.  Please specify the complete file path to 'dot' if you intend to generate graphs locally.";
        }
        # Check .htaccess allows access to generated images
233
        my $webdotdir = bz_locations()->{'webdotdir'};
234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253
        if(-e "$webdotdir/.htaccess") {
            open HTACCESS, "$webdotdir/.htaccess";
            if(! grep(/ \\\.png\$/,<HTACCESS>)) {
                return "Dependency graph images are not accessible.\nAssuming that you have not modified the file, delete $webdotdir/.htaccess and re-run checksetup.pl to rectify.\n";
            }
            close HTACCESS;
        }
    }
    return "";
}

sub check_user_verify_class {
    # doeditparams traverses the list of params, and for each one it checks,
    # then updates. This means that if one param checker wants to look at 
    # other params, it must be below that other one. So you can't have two 
    # params mutually dependent on each other.
    # This means that if someone clears the LDAP config params after setting
    # the login method as LDAP, we won't notice, but all logins will fail.
    # So don't do that.

254
    my $params = Bugzilla->params;
255
    my ($list, $entry) = @_;
256
    $list || return 'You need to specify at least one authentication mechanism';
257 258 259
    for my $class (split /,\s*/, $list) {
        my $res = check_multi($class, $entry);
        return $res if $res;
260
        if ($class eq 'RADIUS') {
261 262 263 264 265 266 267
            if (!Bugzilla->feature('auth_radius')) {
                return "RADIUS support is not available. Run checksetup.pl"
                       . " for more details";
            }
            return "RADIUS servername (RADIUS_server) is missing"
                if !$params->{"RADIUS_server"};
            return "RADIUS_secret is empty" if !$params->{"RADIUS_secret"};
268 269
        }
        elsif ($class eq 'LDAP') {
270 271 272 273 274 275 276
            if (!Bugzilla->feature('auth_ldap')) {
                return "LDAP support is not available. Run checksetup.pl"
                       . " for more details";
            }
            return "LDAP servername (LDAPserver) is missing" 
                if !$params->{"LDAPserver"};
            return "LDAPBaseDN is empty" if !$params->{"LDAPBaseDN"};
277
        }
278 279 280 281 282 283 284 285
    }
    return "";
}

sub check_mail_delivery_method {
    my $check = check_multi(@_);
    return $check if $check;
    my $mailer = shift;
286
    if ($mailer eq 'sendmail' and ON_WINDOWS) {
287 288 289 290 291
        # look for sendmail.exe 
        return "Failed to locate " . SENDMAIL_EXE
            unless -e SENDMAIL_EXE;
    }
    return "";
292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309
}

sub check_maxattachmentsize {
    my $check = check_numeric(@_);
    return $check if $check;
    my $size = shift;
    my $dbh = Bugzilla->dbh;
    if ($dbh->isa('Bugzilla::DB::Mysql')) {
        my (undef, $max_packet) = $dbh->selectrow_array(
            q{SHOW VARIABLES LIKE 'max\_allowed\_packet'});
        my $byte_size = $size * 1024;
        if ($max_packet < $byte_size) {
            return "You asked for a maxattachmentsize of $byte_size bytes,"
                   . " but the max_allowed_packet setting in MySQL currently"
                   . " only allows packets up to $max_packet bytes";
        }
    }
    return "";
310 311
}

312 313 314
sub check_notification {
    my $option = shift;
    my @current_version =
315
        (BUGZILLA_VERSION =~ m/^(\d+)\.(\d+)(?:(rc|\.)(\d+))?\+?$/);
316 317 318 319 320 321
    if ($current_version[1] % 2 && $option eq 'stable_branch_release') {
        return "You are currently running a development snapshot, and so your " .
               "installation is not based on a branch. If you want to be notified " .
               "about the next stable release, you should select " .
               "'latest_stable_release' instead";
    }
322 323 324 325
    if ($option ne 'disabled' && !Bugzilla->feature('updates')) {
        return "Some Perl modules are missing to get notifications about " .
               "new releases. See the output of checksetup.pl for more information";
    }
326 327 328
    return "";
}

329 330
sub check_smtp_auth {
    my $username = shift;
331 332 333
    if ($username and !Bugzilla->feature('smtp_auth')) {
        return "SMTP Authentication is not available. Run checksetup.pl for"
               . " more details";
334 335
    }
    return "";
336 337
}

338 339 340 341 342 343 344 345
sub check_smtp_ssl {
    my $use_ssl = shift;
    if ($use_ssl && !Bugzilla->feature('smtp_ssl')) {
        return "SSL support is not available. Run checksetup.pl for more details";
    }
    return "";
}

346
sub check_theschwartz_available {
347 348
    my $use_queue = shift;
    if ($use_queue && !Bugzilla->feature('jobqueue')) {
349 350 351 352 353
        return "Using the job queue requires that you have certain Perl"
               . " modules installed. See the output of checksetup.pl"
               . " for more information";
    }
    return "";
354
}
355

356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371
# OK, here are the parameter definitions themselves.
#
# Each definition is a hash with keys:
#
# name    - name of the param
# desc    - description of the param (for editparams.cgi)
# type    - see below
# choices - (optional) see below
# default - default value for the param
# checker - (optional) checking function for validating parameter entry
#           It is called with the value of the param as the first arg and a
#           reference to the param's hash as the second argument
#
# The type value can be one of the following:
#
# t -- A short text entry field (suitable for a single line)
372 373
# p -- A short text entry field (as with type = 't'), but the string is
#      replaced by asterisks (appropriate for passwords)
374 375 376 377
# l -- A long text field (suitable for many lines)
# b -- A boolean value (either 1 or 0)
# m -- A list of values, with many selectable (shows up as a select box)
#      To specify the list of values, make the 'choices' key be an array
378 379
#      reference of the valid choices. The 'default' key should be a string
#      with a list of selected values (as a comma-separated list), i.e.:
380 381 382 383 384 385 386 387 388 389 390 391 392 393 394
#       {
#         name => 'multiselect',
#         desc => 'A list of options, choose many',
#         type => 'm',
#         choices => [ 'a', 'b', 'c', 'd' ],
#         default => [ 'a', 'd' ],
#         checker => \&check_multi
#       }
#
#      Here, 'a' and 'd' are the default options, and the user may pick any
#      combination of a, b, c, and d as valid options.
#
#      &check_multi should always be used as the param verification function
#      for list (single and multiple) parameter types.
#
395 396 397 398 399
# o -- A list of values, orderable, and with many selectable (shows up as a
#      JavaScript-enhanced select box if JavaScript is enabled, and a text
#      entry field if not)
#      Set up in the same way as type m.
#
400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432
# s -- A list of values, with one selectable (shows up as a select box)
#      To specify the list of values, make the 'choices' key be an array
#      reference of the valid choices. The 'default' key should be one of
#      those values, i.e.:
#       {
#         name => 'singleselect',
#         desc => 'A list of options, choose one',
#         type => 's',
#         choices => [ 'a', 'b', 'c' ],
#         default => 'b',
#         checker => \&check_multi
#       }
#
#      Here, 'b' is the default option, and 'a' and 'c' are other possible
#      options, but only one at a time! 
#
#      &check_multi should always be used as the param verification function
#      for list (single and multiple) parameter types.

sub get_param_list {
    return;
}

1;

__END__

=head1 NAME

Bugzilla::Config::Common - Parameter checking functions

=head1 DESCRIPTION

433 434 435
All parameter checking functions are called with two parameters: the value to 
check, and a hash with the details of the param (type, default etc.) as defined
in the relevant F<Bugzilla::Config::*> package.
436 437 438 439 440 441 442

=head2 Functions

=over

=item C<check_multi>

443
Checks that a multi-valued parameter (ie types C<s>, C<o> or C<m>) satisfies
444 445 446 447 448 449 450 451 452 453 454
its contraints.

=item C<check_numeric>

Checks that the value is a valid number

=item C<check_regexp>

Checks that the value is a valid regexp

=back