Commit 00bb32b8 authored by Matt Selsky's avatar Matt Selsky Committed by Frédéric Buclin

Bug 412054: Say "deny login" instead of "disable" in User Accounts admin UI

r=gerv a=LpSolit
parent 8496cc97
...@@ -412,10 +412,10 @@ to the webservice, for the duration of the session. ...@@ -412,10 +412,10 @@ to the webservice, for the duration of the session.
The username does not exist, or the password is wrong. The username does not exist, or the password is wrong.
=item 301 (Account Disabled) =item 301 (Login Disabled)
The account has been disabled. A reason may be specified with the The ability to login with this account has been disabled. A reason may be
error. specified with the error.
=item 305 (New Password Required) =item 305 (New Password Required)
......
...@@ -51,7 +51,7 @@ foreach my $arg (@ARGV) ...@@ -51,7 +51,7 @@ foreach my $arg (@ARGV)
print "usage:\n syncLDAP.pl [options]\n\n"; print "usage:\n syncLDAP.pl [options]\n\n";
print "options:\n"; print "options:\n";
print " -r Readonly, do not make changes to Bugzilla tables\n"; print " -r Readonly, do not make changes to Bugzilla tables\n";
print " -d No disable, don't disable users, which are not in LDAP\n"; print " -d No disable, don't disable login by users who are not in LDAP\n";
print " -u No update, don't update users, which have different description in LDAP\n"; print " -u No update, don't update users, which have different description in LDAP\n";
print " -c No create, don't create users, which are in LDAP but not in Bugzilla\n"; print " -c No create, don't create users, which are in LDAP but not in Bugzilla\n";
print " -q Quiet mode, give less output\n"; print " -q Quiet mode, give less output\n";
...@@ -194,7 +194,7 @@ while( my ($create_key, $create_value) = each(%create_users) ) { ...@@ -194,7 +194,7 @@ while( my ($create_key, $create_value) = each(%create_users) ) {
} }
if($quiet == 0) { if($quiet == 0) {
print "\nUsers to disable: \n"; print "\nUsers to disable login for: \n";
while( my ($key, $value) = each(%disable_users) ) { while( my ($key, $value) = each(%disable_users) ) {
print " " . $key . " '" . $value->{'realname'} . "'\n"; print " " . $key . " '" . $value->{'realname'} . "'\n";
} }
...@@ -221,7 +221,7 @@ if($quiet == 0) { ...@@ -221,7 +221,7 @@ if($quiet == 0) {
# now do the DB-Update # now do the DB-Update
### ###
if($readonly == 0) { if($readonly == 0) {
print "Performing DB update:\nPhase 1: disabling not-existing users... " unless $quiet; print "Performing DB update:\nPhase 1: disabling login for users not in LDAP... " unless $quiet;
my $sth_disable = $dbh->prepare( my $sth_disable = $dbh->prepare(
'UPDATE profiles 'UPDATE profiles
......
...@@ -102,8 +102,8 @@ ...@@ -102,8 +102,8 @@
defaultcontent = otheruser.disabledtext defaultcontent = otheruser.disabledtext
onchange = "userDisabledTextOnChange(this);" onchange = "userDisabledTextOnChange(this);"
%]<br> %]<br>
(If non-empty, then the account will be disabled, and this text should (If non-empty, then it will not be possible to log in using this account,
explain why.) and this text should explain why.)
</td> </td>
</tr> </tr>
[% END %] [% END %]
...@@ -42,9 +42,9 @@ ...@@ -42,9 +42,9 @@
[% ELSIF field == 'cryptpassword' %] [% ELSIF field == 'cryptpassword' %]
A new password has been set. A new password has been set.
[% ELSIF field == 'disabledtext' %] [% ELSIF field == 'disabledtext' %]
The disable text has been modified. The "login disabled" text has been modified.
[% ELSIF field == 'is_enabled' %] [% ELSIF field == 'is_enabled' %]
The user has been [% otheruser.is_enabled ? 'enabled' : 'disabled' %]. Logging in with this user account has been [% otheruser.is_enabled ? 'enabled' : 'disabled' %].
[% ELSIF field == 'extern_id' %] [% ELSIF field == 'extern_id' %]
The user's External Login ID has been modified. The user's External Login ID has been modified.
[% ELSIF field == 'disable_mail' %] [% ELSIF field == 'disable_mail' %]
...@@ -97,8 +97,8 @@ ...@@ -97,8 +97,8 @@
successfully. successfully.
[% ELSIF message_tag == "account_disabled" %] [% ELSIF message_tag == "account_disabled" %]
The user account [% account FILTER html %] is disabled, so you Logging in with this user account [% account FILTER html %] is disabled, so
cannot change its password. you cannot change its password.
[% ELSIF message_tag == "attachment_creation_failed" %] [% ELSIF message_tag == "attachment_creation_failed" %]
The [% terms.bug %] was created successfully, but attachment creation The [% terms.bug %] was created successfully, but attachment creation
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment