Skip to content

bugzilla
bugzilla
Commit 110186aa authored by Max Kanat-Alexander's avatar Max Kanat-Alexander
Browse files
Options

The changes to accept positional parameters in XML-RPC meant that sometimes

$params wouldn't just be undef, but actually missing, so validate() was getting @keys where $params should have been. https://bugzilla.mozilla.org/show_bug.cgi?id=577765
parent ebe41c4b
Hide whitespace changes
Inline Side-by-side
Showing with 5 additions and 0 deletions
Bugzilla/WebService/Util.pm
View file @ 110186aa
...@@ -79,6 +79,11 @@ sub _delete_bad_keys { ...@@ -79,6 +79,11 @@ sub _delete_bad_keys {
sub validate { sub validate {
my ($self, $params, @keys) = @_; my ($self, $params, @keys) = @_;
# If $params is defined but not a reference, then we weren't
# sent any parameters at all, and we're getting @keys where
# $params should be.
return ($self, undef) if (defined $params and !ref $params);
# If @keys is not empty then we convert any named # If @keys is not empty then we convert any named
# parameters that have scalar values to arrayrefs # parameters that have scalar values to arrayrefs
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment