Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
bugzilla
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
etersoft
bugzilla
Commits
1355d45b
Commit
1355d45b
authored
Feb 27, 2005
by
mkanat%kerio.com
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Bug 283562: Insecure dependency in parameter 3 of DBI::db (login_to_id forgets a trick_taint)
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=wurblzap, r=joel, a=justdave
parent
1e1498c4
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
2 deletions
+3
-2
User.pm
Bugzilla/User.pm
+3
-2
No files found.
Bugzilla/User.pm
View file @
1355d45b
...
...
@@ -1013,10 +1013,11 @@ sub is_available_username ($;$) {
sub
login_to_id
($)
{
my
(
$login
)
=
(
@_
);
my
$dbh
=
Bugzilla
->
dbh
;
# $login will only be used by the following SELECT statement, so it's safe.
trick_taint
(
$login
);
my
$user_id
=
$dbh
->
selectrow_array
(
"SELECT userid FROM profiles WHERE login_name = ?"
,
undef
,
$login
);
# $user_id should be a positive integer, this makes Taint mode happy
if
(
defined
$user_id
&&
detaint_natural
(
$user_id
))
{
if
(
$user_id
)
{
return
$user_id
;
}
else
{
return
0
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment