Bug 577014: [SINGLE|MULTIPLE]_SELECT custom fields with no new values,…

Bug 577014: [SINGLE|MULTIPLE]_SELECT custom fields with no new values, containing only the default value '---' and marked as mandatory, blocks the user to update/create a bug r/a=LpSolit

Bug 577014: [SINGLE|MULTIPLE]_SELECT custom fields with no new values,…
15659830 · Koosha Khajeh Moogahi · Frédéric Buclin · 4a73f6aa · 15659830
Commit 15659830 authored Jun 09, 2012 by Koosha Khajeh Moogahi Committed by Frédéric Buclin Jun 09, 2012
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 0 deletions

Bug.pm Bugzilla/Bug.pm +6 -0

No files found.
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -1920,6 +1920,12 @@ sub _check_field_is_mandatory {

    return if !$field->is_visible_on_bug($params || $invocant);

+    return if ($field->type == FIELD_TYPE_SINGLE_SELECT
+                 && scalar @{ get_legal_field_values($field->name) } == 1);
+
+    return if ($field->type == FIELD_TYPE_MULTI_SELECT
+                 && !scalar @{ get_legal_field_values($field->name) });
+
    if (ref($value) eq 'ARRAY') {
        $value = join('', @$value);
    }