Patch for bug 123077; improve the ValidatePassword sub so that a password change…

Patch for bug 123077; improve the ValidatePassword sub so that a password change is no longer accepted with a blank second field; r=kiko, a=justdave.

Patch for bug 123077; improve the ValidatePassword sub so that a password change…
261e207c · jocuri%softhome.net · 82303e4a · 261e207c · 261e207c
Commit 261e207c authored Mar 03, 2004 by jocuri%softhome.net
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 3 deletions

globals.pl globals.pl +1 -1

userprefs.cgi userprefs.cgi +1 -2

No files found.
--- a/globals.pl
+++ b/globals.pl
@@ -706,7 +706,7 @@ sub ValidatePassword {
        ThrowUserError("password_too_short");
    } elsif (length($password) > 16) {
        ThrowUserError("password_too_long");
-    } elsif ($matchpassword && $password ne $matchpassword) { 
+    } elsif ((defined $matchpassword) && ($password ne $matchpassword)) {
        ThrowUserError("passwords_dont_match");
    }
 }

--- a/userprefs.cgi
+++ b/userprefs.cgi
@@ -97,9 +97,8 @@ sub SaveAccount {

        if ($pwd1 ne "" || $pwd2 ne "")
        {
-            ($pwd1 eq $pwd2) || ThrowUserError("passwords_dont_match");
            $::FORM{'new_password1'} || ThrowUserError("new_password_missing");
-            ValidatePassword($pwd1);
+            ValidatePassword($pwd1, $pwd2);
        
            my $cryptedpassword = SqlQuote(Crypt($pwd1));
            SendSQL("UPDATE profiles