Fix for bug 253562: Hours Worked (actual_time) is being listed as 1.

Cleans up Bugzilla::Bug::actual_time to do things the right way (dbi, Bugzilla->user) and apparently fixes a problem limited to some platforms. r=joel, a=justdave.

Fix for bug 253562: Hours Worked (actual_time) is being listed as 1.
27749749 · kiko%async.com.br · 1e04722b · 27749749
Commit 27749749 authored Aug 05, 2004 by kiko%async.com.br
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 5 deletions

Bug.pm Bugzilla/Bug.pm +6 -5

No files found.
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -289,12 +289,13 @@ sub actual_time {

    return $self->{'actual_time'} if exists $self->{'actual_time'};

-    if (&::UserInGroup(Param("timetrackinggroup"))) {
-        &::SendSQL("SELECT SUM(work_time)
-               FROM longdescs WHERE longdescs.bug_id=$self->{bug_id}");
-        $self->{'actual_time'} = &::FetchSQLData();
-    }
+    return undef unless Bugzilla->user->in_group(Param("timetrackinggroup"));

+    my $sth = Bugzilla->dbh->prepare("SELECT SUM(work_time)
+                                      FROM longdescs 
+                                      WHERE longdescs.bug_id=?");
+    $sth->execute($self->{bug_id});
+    $self->{'actual_time'} = $sth->fetchrow_array();
    return $self->{'actual_time'};
 }