Commit 2cb85ad6 authored by Byron Jones's avatar Byron Jones

Bug 1047405: Comment tagging GUI not fully localizable because of text in…

Bug 1047405: Comment tagging GUI not fully localizable because of text in Javascript instead of template r=sgreen,a=glob
parent 424b21e3
......@@ -20,6 +20,10 @@ YAHOO.bugzilla.commentTagging = {
can_edit : false,
pending : {},
label : '',
min_len_error: '',
max_len_error: '',
init : function(can_edit) {
this.can_edit = can_edit;
this.ctag_div = Dom.get('bz_ctag_div');
......@@ -185,7 +189,7 @@ YAHOO.bugzilla.commentTagging = {
tags.sort();
if (tags.length) {
var div = document.createElement('div');
div.appendChild(document.createTextNode('Comment Tags:'));
div.appendChild(document.createTextNode(this.label));
var ul = document.createElement('ul');
ul.id = 'comment_tags_collapse_expand';
div.appendChild(ul);
......@@ -260,9 +264,9 @@ YAHOO.bugzilla.commentTagging = {
if (tag == '')
continue;
if (tag.length < YAHOO.bugzilla.commentTagging.min_len)
throw new Error("Comment tags must be at least " + this.min_len + " characters.");
throw new Error(this.min_len_error)
if (tag.length > YAHOO.bugzilla.commentTagging.max_len)
throw new Error("Comment tags cannot be longer than " + this.min_len + " characters.");
throw new Error(this.max_len_error)
// append new tag
if (bz_isValueInArrayIgnoreCase(tags, tag))
continue;
......
......@@ -29,6 +29,13 @@
YAHOO.bugzilla.commentTagging.init([% user.can_tag_comments ? 'true' : 'false' %]);
YAHOO.bugzilla.commentTagging.min_len = [% constants.MIN_COMMENT_TAG_LENGTH FILTER js %];
YAHOO.bugzilla.commentTagging.max_len = [% constants.MAX_COMMENT_TAG_LENGTH FILTER js %];
YAHOO.bugzilla.commentTagging.label = 'Comment Tags:';
YAHOO.bugzilla.commentTagging.min_len_error =
'Comment tags must be at least
[%~ " " _ constants.MIN_COMMENT_TAG_LENGTH FILTER js %] characters.';
YAHOO.bugzilla.commentTagging.max_len_error =
'Comment tags cannot be longer than
[%~ " " _ constants.MAX_COMMENT_TAG_LENGTH FILTER js %] characters.';
</script>
[% END %]
[% END %]
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment