Commit 2cc8fe72 authored by gerv%gerv.net's avatar gerv%gerv.net

Bug 514703 - revert changes to bug link detection algorithm. r,a=LpSolit

parent 8055714d
...@@ -156,11 +156,6 @@ sub quoteUrls { ...@@ -156,11 +156,6 @@ sub quoteUrls {
my $chr1 = chr(1); my $chr1 = chr(1);
$text =~ s/\0/$chr1\0/g; $text =~ s/\0/$chr1\0/g;
# If the comment is already wrapped, we should ignore newlines when
# looking for matching regexps. Else we should take them into account.
my $s = ($comment && $comment->already_wrapped)
? qr/\s/ : qr/[[:blank:]]/;
# However, note that adding the title (for buglinks) can affect things # However, note that adding the title (for buglinks) can affect things
# In particular, attachment matches go before bug titles, so that titles # In particular, attachment matches go before bug titles, so that titles
# with 'attachment 1' don't double match. # with 'attachment 1' don't double match.
...@@ -230,7 +225,7 @@ sub quoteUrls { ...@@ -230,7 +225,7 @@ sub quoteUrls {
~<a href=\"mailto:$2\">$1$2</a>~igx; ~<a href=\"mailto:$2\">$1$2</a>~igx;
# attachment links # attachment links
$text =~ s~\b(attachment$s*\#?$s*(\d+)) $text =~ s~\b(attachment\s*\#?\s*(\d+))
~($things[$count++] = get_attachment_link($2, $1)) && ~($things[$count++] = get_attachment_link($2, $1)) &&
("\0\0" . ($count-1) . "\0\0") ("\0\0" . ($count-1) . "\0\0")
~egmxi; ~egmxi;
...@@ -243,9 +238,9 @@ sub quoteUrls { ...@@ -243,9 +238,9 @@ sub quoteUrls {
# Also, we can't use $bug_re?$comment_re? because that will match the # Also, we can't use $bug_re?$comment_re? because that will match the
# empty string # empty string
my $bug_word = get_text('term', { term => 'bug' }); my $bug_word = get_text('term', { term => 'bug' });
my $bug_re = qr/\Q$bug_word\E$s*\#?$s*(\d+)/i; my $bug_re = qr/\Q$bug_word\E\s*\#?\s*(\d+)/i;
my $comment_re = qr/comment$s*\#?$s*(\d+)/i; my $comment_re = qr/comment\s*\#?\s*(\d+)/i;
$text =~ s~\b($bug_re(?:$s*,?$s*$comment_re)?|$comment_re) $text =~ s~\b($bug_re(?:\s*,?\s*$comment_re)?|$comment_re)
~ # We have several choices. $1 here is the link, and $2-4 are set ~ # We have several choices. $1 here is the link, and $2-4 are set
# depending on which part matched # depending on which part matched
(defined($2) ? get_bug_link($2, $1, { comment_num => $3 }) : (defined($2) ? get_bug_link($2, $1, { comment_num => $3 }) :
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment