Commit 2ebb8429 authored by lpsolit%gmail.com's avatar lpsolit%gmail.com

Bug 238207: Comment autolinkification on midair page points to wrong cgi - Patch…

Bug 238207: Comment autolinkification on midair page points to wrong cgi - Patch by Olav Vitters <bugzilla-mozilla@bkor.dhs.org> r=LpSolit a=justdave
parent 8508ede5
...@@ -402,7 +402,15 @@ sub create { ...@@ -402,7 +402,15 @@ sub create {
# as prefix. In addition it replaces a ' ' by a '_'. # as prefix. In addition it replaces a ' ' by a '_'.
css_class_quote => \&Bugzilla::Util::css_class_quote , css_class_quote => \&Bugzilla::Util::css_class_quote ,
quoteUrls => \&::quoteUrls , quoteUrls => [ sub {
my ($context, $bug) = @_;
return sub {
my $text = shift;
return &::quoteUrls($text, $bug);
};
},
1
],
bug_link => [ sub { bug_link => [ sub {
my ($context, $bug) = @_; my ($context, $bug) = @_;
......
...@@ -485,7 +485,7 @@ sub get_component_name { ...@@ -485,7 +485,7 @@ sub get_component_name {
# If you want to modify this routine, read the comments carefully # If you want to modify this routine, read the comments carefully
sub quoteUrls { sub quoteUrls {
my ($text) = (@_); my ($text, $curr_bugid) = (@_);
return $text unless $text; return $text unless $text;
# We use /g for speed, but uris can have other things inside them # We use /g for speed, but uris can have other things inside them
...@@ -547,6 +547,9 @@ sub quoteUrls { ...@@ -547,6 +547,9 @@ sub quoteUrls {
("\0\0" . ($count-1) . "\0\0") ("\0\0" . ($count-1) . "\0\0")
~egmxi; ~egmxi;
# Current bug ID this comment belongs to
my $current_bugurl = $curr_bugid ? "show_bug.cgi?id=$curr_bugid" : "";
# This handles bug a, comment b type stuff. Because we're using /g # This handles bug a, comment b type stuff. Because we're using /g
# we have to do this in one pattern, and so this is semi-messy. # we have to do this in one pattern, and so this is semi-messy.
# Also, we can't use $bug_re?$comment_re? because that will match the # Also, we can't use $bug_re?$comment_re? because that will match the
...@@ -557,7 +560,7 @@ sub quoteUrls { ...@@ -557,7 +560,7 @@ sub quoteUrls {
~ # We have several choices. $1 here is the link, and $2-4 are set ~ # We have several choices. $1 here is the link, and $2-4 are set
# depending on which part matched # depending on which part matched
(defined($2) ? GetBugLink($2,$1,$3) : (defined($2) ? GetBugLink($2,$1,$3) :
"<a href=\"#c$4\">$1</a>") "<a href=\"$current_bugurl#c$4\">$1</a>")
~egox; ~egox;
# Old duplicate markers # Old duplicate markers
......
...@@ -149,7 +149,7 @@ ...@@ -149,7 +149,7 @@
[% wrapped_comment = comment.body FILTER wrap_comment %] [% wrapped_comment = comment.body FILTER wrap_comment %]
[% END %] [% END %]
<pre[% ' id="comment_text_' _ count _ '"' IF mode == "edit" %]> <pre[% ' id="comment_text_' _ count _ '"' IF mode == "edit" %]>
[%- wrapped_comment FILTER quoteUrls -%] [%- wrapped_comment FILTER quoteUrls(bug.bug_id) -%]
</pre> </pre>
</div> </div>
[% END %] [% END %]
......
...@@ -57,7 +57,7 @@ ...@@ -57,7 +57,7 @@
<p> <p>
Added the comment(s): Added the comment(s):
<blockquote> <blockquote>
[% PROCESS "bug/comments.html.tmpl" %] [% PROCESS "bug/comments.html.tmpl" bug = { 'bug_id' => bug_id } %]
</blockquote> </blockquote>
</p> </p>
[% END %] [% END %]
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment