Bug 303824: BugMail should ignore deleted or renamed user accounts - Patch by…

Bug 303824: BugMail should ignore deleted or renamed user accounts - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap a=justdave

Bug 303824: BugMail should ignore deleted or renamed user accounts - Patch by…
2fe49f40 · lpsolit%gmail.com · 9ab537a5 · 2fe49f40
Commit 2fe49f40 authored Aug 13, 2005 by lpsolit%gmail.com
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 4 deletions

BugMail.pm Bugzilla/BugMail.pm +7 -4

No files found.
--- a/Bugzilla/BugMail.pm
+++ b/Bugzilla/BugMail.pm
@@ -358,17 +358,20 @@ sub ProcessOneBug {
        if ($old) {
            # You can't stop being the reporter, and mail isn't sent if you
            # remove your vote.
+            # Ignore people whose user account has been deleted or renamed.
            if ($what eq "CC") {
                foreach my $cc_user (split(/[\s,]+/, $old)) {
-                    push(@{$recipients{&::DBNameToIdAndCheck($cc_user)}},
+                    my $uid = login_to_id($cc_user);
-                         REL_CC);
+                    push(@{$recipients{$uid}}, REL_CC) if $uid;
                }
            }
            elsif ($what eq "QAContact") {
-                push(@{$recipients{&::DBNameToIdAndCheck($old)}}, REL_QA);
+                my $uid = login_to_id($old);
+                push(@{$recipients{$uid}}, REL_QA) if $uid;
            }
            elsif ($what eq "AssignedTo") {
-                push(@{$recipients{&::DBNameToIdAndCheck($old)}}, REL_ASSIGNEE);
+                my $uid = login_to_id($old);
+                push(@{$recipients{$uid}}, REL_ASSIGNEE) if $uid;
            }
        }
    }