Commit 34e99706 authored by Kent Rogers's avatar Kent Rogers Committed by Max Kanat-Alexander

Bug 271913: Do not force the user to comment when adding Hours Worked

r=mkanat, a=mkanat
parent 20ed8a92
......@@ -2243,11 +2243,7 @@ sub add_comment {
$comment = $self->_check_comment($comment);
$params ||= {};
if (exists $params->{work_time}) {
$params->{work_time} = $self->_check_work_time($params->{work_time});
ThrowUserError('comment_required')
if $comment eq '' && $params->{work_time} != 0;
}
$params->{work_time} = $self->_check_work_time($params->{work_time});
if (exists $params->{type}) {
$params->{type} = $self->_check_comment_type($params->{type});
}
......@@ -2257,7 +2253,7 @@ sub add_comment {
}
# XXX We really should check extra_data, too.
if ($comment eq '' && !($params->{type} || $params->{work_time})) {
if ($comment eq '' && !($params->{type} || abs($params->{work_time}))) {
return;
}
......
......@@ -94,6 +94,7 @@
[% DEFAULT start_at = 0 mode = "show" %]
[% timetracking_only = (comment_body == '' && comment.work_time != 0) %]
[% sort_order = user.settings.comment_sort_order.value %]
[%# NOTE: (start_at > 0) means we came here from a midair collision,
......@@ -157,6 +158,7 @@
[% BLOCK a_comment %]
[% RETURN IF comment.is_private AND ! user.is_insider %]
[% RETURN IF timetracking_only AND !user.in_group(Param('timetrackinggroup')) %]
<div id="c[% count %]" class="bz_comment[% " bz_private" IF comment.is_private %]
[% " bz_comment_hilite" IF marks.$count %]
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment