Bug 533363: [PostgreSQL] Using "Bug ID contains foo" in boolean charts or…

Bug 533363: [PostgreSQL] Using "Bug ID contains foo" in boolean charts or "Exclude bug numbered" charts crash PostgreSQL 8.3 and newer (non-character data types are no longer automatically cast to TEXT) Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat

Bug 533363: [PostgreSQL] Using "Bug ID contains foo" in boolean charts or…
39af8fd0 · Frédéric Buclin · Max Kanat-Alexander · 26426fe8 · 39af8fd0
Commit 39af8fd0 authored Feb 01, 2010 by Frédéric Buclin Committed by Max Kanat-Alexander Feb 01, 2010
Hide whitespace changes
Inline Side-by-side

Showing with 14 additions and 2 deletions

Pg.pm Bugzilla/DB/Pg.pm +14 -2

No files found.
--- a/Bugzilla/DB/Pg.pm
+++ b/Bugzilla/DB/Pg.pm
@@ -100,13 +100,25 @@ sub sql_group_concat {
    return "array_to_string(array_accum($text), $separator)";
 }

+sub sql_istring {
+    my ($self, $string) = @_;
+
+    return "LOWER(${string}::text)";
+}
+
+sub sql_position {
+    my ($self, $fragment, $text) = @_;
+
+    return "POSITION($fragment IN ${text}::text)";
+}
+
 sub sql_regexp {
    my ($self, $expr, $pattern, $nocheck, $real_pattern) = @_;
    $real_pattern ||= $pattern;

    $self->bz_check_regexp($real_pattern) if !$nocheck;

-    return "$expr ~* $pattern";
+    return "${expr}::text ~* $pattern";
 }

 sub sql_not_regexp {
@@ -115,7 +127,7 @@ sub sql_not_regexp {

    $self->bz_check_regexp($real_pattern) if !$nocheck;

-    return "$expr !~* $pattern" 
+    return "${expr}::text !~* $pattern" 
 }

 sub sql_limit {