The mod_perl CGI.pm fix caused Bugzilla.pm to throw a warning on every

invocation that didn't have $SIG{TERM} and $SIG{PIPE} set (for example, during command-line scripts). https://bugzilla.mozilla.org/show_bug.cgi?id=637977

The mod_perl CGI.pm fix caused Bugzilla.pm to throw a warning on every
40769a8b · Max Kanat-Alexander · ebc758fb · 40769a8b
Commit 40769a8b authored Mar 13, 2011 by Max Kanat-Alexander
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

Bugzilla.pm Bugzilla.pm +3 -2

No files found.
--- a/Bugzilla.pm
+++ b/Bugzilla.pm
@@ -650,8 +650,9 @@ sub _cleanup {

    # These are both set by CGI.pm but need to be undone so that
    # Apache can actually shut down its children if it needs to.
-    $SIG{TERM} = 'DEFAULT' if $SIG{TERM} eq 'IGNORE';
-    $SIG{PIPE} = 'DEFAULT' if $SIG{PIPE} eq 'IGNORE';
+    foreach my $signal (qw(TERM PIPE)) {
+        $SIG{$signal} = 'DEFAULT' if $SIG{$signal} && $SIG{$signal} eq 'IGNORE';
+    }
 }

 sub END {