Bug 645433: Bugzilla->error_mode( ERROR_MODE_WEBPAGE ) doesn't change Bugzilla->error_mode

r/a=LpSolit

Bug 645433: Bugzilla->error_mode( ERROR_MODE_WEBPAGE ) doesn't change Bugzilla->error_mode
41beb175 · Koosha Khajeh Moogahi · Frédéric Buclin · 4862600f · 41beb175
Commit 41beb175 authored Apr 24, 2012 by Koosha Khajeh Moogahi Committed by Frédéric Buclin Apr 24, 2012
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 2 deletions

Bugzilla.pm Bugzilla.pm +8 -2

No files found.
--- a/Bugzilla.pm
+++ b/Bugzilla.pm
@@ -445,8 +445,14 @@ sub error_mode {
    if (defined $newval) {
        $class->request_cache->{error_mode} = $newval;
    }
-    return $class->request_cache->{error_mode}
-        || (i_am_cgi() ? ERROR_MODE_WEBPAGE : ERROR_MODE_DIE);
+
+    # XXX - Once we require Perl 5.10.1, this test can be replaced by //.
+    if (exists $class->request_cache->{error_mode}) {
+        return $class->request_cache->{error_mode};
+    }
+    else {
+        return (i_am_cgi() ? ERROR_MODE_WEBPAGE : ERROR_MODE_DIE);
+    }
 }

 # This is used only by Bugzilla::Error to throw errors.