Bug 529223: The JSON-RPC interface was not working at all with JSON-RPC 1.0,…

Bug 529223: The JSON-RPC interface was not working at all with JSON-RPC 1.0, because it was mis-handling input parameters. Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat

Bug 529223: The JSON-RPC interface was not working at all with JSON-RPC 1.0,…
437b14a0 · mkanat%bugzilla.org · 62d123f6 · 437b14a0
Commit 437b14a0 authored Nov 18, 2009 by mkanat%bugzilla.org
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 0 deletions

JSONRPC.pm Bugzilla/WebService/Server/JSONRPC.pm +6 -0

No files found.
--- a/Bugzilla/WebService/Server/JSONRPC.pm
+++ b/Bugzilla/WebService/Server/JSONRPC.pm
@@ -114,8 +114,10 @@ sub _argument_type_check {

    # JSON-RPC 1.0 requires all parameters to be passed as an array, so
    # we just pull out the first item and assume it's an object.
+    my $params_is_array;
    if (ref $params eq 'ARRAY') {
        $params = $params->[0];
+        $params_is_array = 1;
    }

    taint_data($params);
@@ -151,6 +153,10 @@ sub _argument_type_check {
    eval "package $new_class;$isa_string;";
    bless $self, $new_class;

+    if ($params_is_array) {
+        $params = [$params];
+    }
+
    return $params;
 }