Commit 4c93d5fb authored by lpsolit%gmail.com's avatar lpsolit%gmail.com

Bug 398428: After creating or editing an attachment, immediately display the bug…

Bug 398428: After creating or editing an attachment, immediately display the bug it belongs to - Patch by Fré©ric Buclin <LpSolit@gmail.com> r=ghendricks a=LpSolit
parent 76e5ced1
...@@ -72,6 +72,12 @@ local our $vars = {}; ...@@ -72,6 +72,12 @@ local our $vars = {};
# Determine whether to use the action specified by the user or the default. # Determine whether to use the action specified by the user or the default.
my $action = $cgi->param('action') || 'view'; my $action = $cgi->param('action') || 'view';
# Determine if PatchReader is installed
eval {
require PatchReader;
$vars->{'patchviewerinstalled'} = 1;
};
if ($action eq "view") if ($action eq "view")
{ {
view(); view();
...@@ -397,6 +403,10 @@ sub insert { ...@@ -397,6 +403,10 @@ sub insert {
$vars->{'mailrecipients'} = { 'changer' => $user->login, $vars->{'mailrecipients'} = { 'changer' => $user->login,
'owner' => $owner }; 'owner' => $owner };
$vars->{'attachment'} = $attachment; $vars->{'attachment'} = $attachment;
# We cannot reuse the $bug object as delta_ts has eventually been updated
# since the object was created.
$vars->{'bugs'} = [new Bugzilla::Bug($bugid)];
$vars->{'header_done'} = 1;
$vars->{'contenttypemethod'} = $cgi->param('contenttypemethod'); $vars->{'contenttypemethod'} = $cgi->param('contenttypemethod');
print $cgi->header(); print $cgi->header();
...@@ -439,11 +449,6 @@ sub edit { ...@@ -439,11 +449,6 @@ sub edit {
$vars->{'bugsummary'} = $bugsummary; $vars->{'bugsummary'} = $bugsummary;
$vars->{'attachments'} = $bugattachments; $vars->{'attachments'} = $bugattachments;
# Determine if PatchReader is installed
eval {
require PatchReader;
$vars->{'patchviewerinstalled'} = 1;
};
print $cgi->header(); print $cgi->header();
# Generate and return the UI (HTML page) from the appropriate template. # Generate and return the UI (HTML page) from the appropriate template.
...@@ -591,6 +596,10 @@ sub update { ...@@ -591,6 +596,10 @@ sub update {
# Define the variables and functions that will be passed to the UI template. # Define the variables and functions that will be passed to the UI template.
$vars->{'mailrecipients'} = { 'changer' => Bugzilla->user->login }; $vars->{'mailrecipients'} = { 'changer' => Bugzilla->user->login };
$vars->{'attachment'} = $attachment; $vars->{'attachment'} = $attachment;
# We cannot reuse the $bug object as delta_ts has eventually been updated
# since the object was created.
$vars->{'bugs'} = [new Bugzilla::Bug($bug->id)];
$vars->{'header_done'} = 1;
print $cgi->header(); print $cgi->header();
......
...@@ -27,7 +27,7 @@ ...@@ -27,7 +27,7 @@
[% PROCESS global/variables.none.tmpl %] [% PROCESS global/variables.none.tmpl %]
[% PROCESS global/header.html.tmpl [% PROCESS global/header.html.tmpl
title = "Changes Submitted" title = "Attachment $attachment.id added to $terms.Bug $attachment.bug_id"
%] %]
<dl> <dl>
...@@ -60,7 +60,7 @@ ...@@ -60,7 +60,7 @@
<p> <p>
<a href="attachment.cgi?bugid=[% attachment.bug_id %]&amp;action=enter">Create <a href="attachment.cgi?bugid=[% attachment.bug_id %]&amp;action=enter">Create
Another Attachment to [% terms.Bug %] #[% attachment.bug_id %]</a> Another Attachment to [% terms.Bug %] [%+ attachment.bug_id %]</a>
</p> </p>
[% PROCESS global/footer.html.tmpl %] [% PROCESS bug/show.html.tmpl %]
...@@ -26,7 +26,7 @@ ...@@ -26,7 +26,7 @@
[% PROCESS global/variables.none.tmpl %] [% PROCESS global/variables.none.tmpl %]
[% PROCESS global/header.html.tmpl [% PROCESS global/header.html.tmpl
title = "Changes Submitted" title = "Changes Submitted to Attachment $attachment.id of $terms.Bug $attachment.bug_id"
%] %]
<dl> <dl>
...@@ -41,4 +41,4 @@ ...@@ -41,4 +41,4 @@
</dd> </dd>
</dl> </dl>
[% PROCESS global/footer.html.tmpl %] [% PROCESS bug/show.html.tmpl %]
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment