Commit 4e55e090 authored by Byron Jones's avatar Byron Jones

Bug 977137: Comment and Preview tabs need accessibility markup

r=dkl, a=justdave
parent 146bad33
...@@ -994,16 +994,22 @@ function show_comment_preview(bug_id) { ...@@ -994,16 +994,22 @@ function show_comment_preview(bug_id) {
var Dom = YAHOO.util.Dom; var Dom = YAHOO.util.Dom;
var comment = document.getElementById('comment'); var comment = document.getElementById('comment');
var preview = document.getElementById('comment_preview'); var preview = document.getElementById('comment_preview');
if (!comment || !preview) return; if (!comment || !preview) return;
if (Dom.hasClass('comment_preview_tab', 'active_comment_tab')) return; if (Dom.hasClass('comment_preview_tab', 'active_comment_tab')) return;
preview.style.width = (comment.clientWidth - 4) + 'px'; preview.style.width = (comment.clientWidth - 4) + 'px';
preview.style.height = comment.offsetHeight + 'px'; preview.style.height = comment.offsetHeight + 'px';
var comment_tab = document.getElementById('comment_tab');
Dom.addClass(comment, 'bz_default_hidden'); Dom.addClass(comment, 'bz_default_hidden');
Dom.removeClass('comment_tab', 'active_comment_tab'); Dom.removeClass(comment_tab, 'active_comment_tab');
comment_tab.setAttribute('aria-selected', 'false');
var preview_tab = document.getElementById('comment_preview_tab');
Dom.removeClass(preview, 'bz_default_hidden'); Dom.removeClass(preview, 'bz_default_hidden');
Dom.addClass('comment_preview_tab', 'active_comment_tab'); Dom.addClass(preview_tab, 'active_comment_tab');
preview_tab.setAttribute('aria-selected', 'true');
Dom.addClass('comment_preview_error', 'bz_default_hidden'); Dom.addClass('comment_preview_error', 'bz_default_hidden');
...@@ -1054,8 +1060,13 @@ function show_comment_edit() { ...@@ -1054,8 +1060,13 @@ function show_comment_edit() {
if (!comment || !preview) return; if (!comment || !preview) return;
if (YAHOO.util.Dom.hasClass(comment, 'active_comment_tab')) return; if (YAHOO.util.Dom.hasClass(comment, 'active_comment_tab')) return;
var preview_tab = document.getElementById('comment_preview_tab');
YAHOO.util.Dom.addClass(preview, 'bz_default_hidden'); YAHOO.util.Dom.addClass(preview, 'bz_default_hidden');
YAHOO.util.Dom.removeClass('comment_preview_tab', 'active_comment_tab'); YAHOO.util.Dom.removeClass(preview_tab, 'active_comment_tab');
preview_tab.setAttribute('aria-selected', 'false');
var comment_tab = document.getElementById('comment_tab');
YAHOO.util.Dom.removeClass(comment, 'bz_default_hidden'); YAHOO.util.Dom.removeClass(comment, 'bz_default_hidden');
YAHOO.util.Dom.addClass('comment_tab', 'active_comment_tab'); YAHOO.util.Dom.addClass(comment_tab, 'active_comment_tab');
comment_tab.setAttribute('aria-selected', 'true');
} }
...@@ -13,10 +13,12 @@ ...@@ -13,10 +13,12 @@
#%] #%]
[% IF feature_enabled('jsonrpc') %] [% IF feature_enabled('jsonrpc') %]
<div id="comment_tabs"> <div id="comment_tabs" role="tablist">
<div id="comment_tab" class="comment_tab active_comment_tab" <div id="comment_tab" class="comment_tab active_comment_tab"
role="tab" aria-selected="true"
onclick="show_comment_edit()">Comment</div> onclick="show_comment_edit()">Comment</div>
<div id="comment_preview_tab" class="comment_tab" <div id="comment_preview_tab" class="comment_tab"
role="tab" aria-selected="false"
onclick="show_comment_preview([% bug.id FILTER none %])">Preview</div> onclick="show_comment_preview([% bug.id FILTER none %])">Preview</div>
</div> </div>
[% END %] [% END %]
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment